-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch '24814-pipeline-tabs' into 'master'
Pipelines tabs ## What does this MR do? Changes the URL when the builds tab is clicked making it possible to be shared. 1. Adds a standard way to handle linked tabs: * This behaviour is already present in the merge requests, commit and user `show` page. * This MR introduces a reusable way to accomplish this behaviour for pages with static content. 2. Adds test: * For the linked tabs reusable class * For the pipelines tabs ## Why was this MR needed? To allow having a sharable URL that represented the opened tab  ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24814 See merge request !7709
Showing
- app/assets/javascripts/dispatcher.js.es6 11 additions, 1 deletionapp/assets/javascripts/dispatcher.js.es6
- app/assets/javascripts/extensions/element.js.es6 14 additions, 3 deletionsapp/assets/javascripts/extensions/element.js.es6
- app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js.es6 113 additions, 0 deletions...assets/javascripts/lib/utils/bootstrap_linked_tabs.js.es6
- app/assets/javascripts/pipelines.js.es6 8 additions, 1 deletionapp/assets/javascripts/pipelines.js.es6
- app/controllers/projects/pipelines_controller.rb 9 additions, 1 deletionapp/controllers/projects/pipelines_controller.rb
- app/views/projects/pipelines/_with_tabs.html.haml 10 additions, 7 deletionsapp/views/projects/pipelines/_with_tabs.html.haml
- app/views/projects/pipelines/show.html.haml 1 addition, 1 deletionapp/views/projects/pipelines/show.html.haml
- changelogs/unreleased/24814-pipeline-tabs.yml 4 additions, 0 deletionschangelogs/unreleased/24814-pipeline-tabs.yml
- config/routes/project.rb 1 addition, 0 deletionsconfig/routes/project.rb
- spec/features/projects/pipelines/pipeline_spec.rb 154 additions, 0 deletionsspec/features/projects/pipelines/pipeline_spec.rb
- spec/features/projects/pipelines/pipelines_spec.rb 0 additions, 59 deletionsspec/features/projects/pipelines/pipelines_spec.rb
- spec/javascripts/bootstrap_linked_tabs_spec.js.es6 55 additions, 0 deletionsspec/javascripts/bootstrap_linked_tabs_spec.js.es6
- spec/javascripts/fixtures/linked_tabs.html.haml 13 additions, 0 deletionsspec/javascripts/fixtures/linked_tabs.html.haml
Loading
Please register or sign in to comment