Skip to content
Snippets Groups Projects
Commit 67ca15bb authored by Rémy Coutable's avatar Rémy Coutable
Browse files

Merge branch 'fix-systemhook-api' into 'master'

API: Return 400 when creating a systemhook fails

Closes #23335

See merge request !7350
parents 55e0065b 659ef546
No related branches found
No related tags found
1 merge request!7350API: Return 400 when creating a systemhook fails
Pipeline #
---
title: Return 400 when creating a system hook fails
merge_request: 7350
author: Robert Schilling
Loading
Loading
@@ -32,7 +32,7 @@ module API
if hook.save
present hook, with: Entities::Hook
else
not_found!
render_validation_error!(hook)
end
end
 
Loading
Loading
Loading
Loading
@@ -52,6 +52,12 @@ describe API::API, api: true do
expect(response).to have_http_status(400)
end
 
it "responds with 400 if url is invalid" do
post api("/hooks", admin), url: 'hp://mep.mep'
expect(response).to have_http_status(400)
end
it "does not create new hook without url" do
expect do
post api("/hooks", admin)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment