Skip to content
Snippets Groups Projects
Commit 869de96e authored by Lin Jen-Shin's avatar Lin Jen-Shin
Browse files

bang to indicate that this method could raise an exception

parent aac297ad
No related branches found
No related tags found
1 merge request!3363Implement #3243 New Issue by email
Loading
Loading
@@ -40,7 +40,7 @@ module Gitlab
author = sent_notification.recipient
project = sent_notification.project
 
validate_permission(author, project, :create_note)
validate_permission!(author, project, :create_note)
 
raise NoteableNotFoundError unless sent_notification.noteable
 
Loading
Loading
@@ -59,7 +59,7 @@ module Gitlab
end
 
def process_create_issue
validate_permission(message_sender, message_project, :create_issue)
validate_permission!(message_sender, message_project, :create_issue)
 
issue = Issues::CreateService.new(
message_project,
Loading
Loading
@@ -78,7 +78,7 @@ module Gitlab
end
end
 
def validate_permission(author, project, permission)
def validate_permission!(author, project, permission)
raise UserNotFoundError unless author
raise UserBlockedError if author.blocked?
# TODO: Give project not found error if author cannot read project
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment