Skip to content
Snippets Groups Projects
Commit 8bfc4645 authored by Josh Frye's avatar Josh Frye Committed by Josh Frye
Browse files

Show 'New Merge Request' buttons on canonical repo.

parent bfb3c8d9
Branches
Tags
1 merge request!2300Show 'New Merge Request' buttons on canonical repo. (by @joshfng)
Loading
@@ -91,6 +91,8 @@ v 8.3.0
Loading
@@ -91,6 +91,8 @@ v 8.3.0
- Do not show build status unless builds are enabled and `.gitlab-ci.yml` is present - Do not show build status unless builds are enabled and `.gitlab-ci.yml` is present
- Persist runners registration token in database - Persist runners registration token in database
- Fix online editor should not remove newlines at the end of the file - Fix online editor should not remove newlines at the end of the file
- Expose Git's version in the admin area
- Show "New Merge Request" buttons on canonical repos when you have a fork (Josh Frye)
   
v 8.2.3 v 8.2.3
- Fix application settings cache not expiring after changes (Stan Hu) - Fix application settings cache not expiring after changes (Stan Hu)
Loading
Loading
Loading
@@ -8,11 +8,12 @@
Loading
@@ -8,11 +8,12 @@
= link_to url_for_new_issue(@project, only_path: true) do = link_to url_for_new_issue(@project, only_path: true) do
= icon('exclamation-circle fw') = icon('exclamation-circle fw')
New issue New issue
- if can?(current_user, :create_merge_request, @project) - merge_project = can?(current_user, :create_merge_request, @project) ? @project : current_user.fork_of(@project)
- if merge_project
%li %li
= link_to new_namespace_project_merge_request_path(@project.namespace, @project) do = link_to new_namespace_project_merge_request_path(merge_project.namespace, merge_project) do
= icon('tasks fw') = icon('tasks fw')
New merge request New Merge Request
- if can?(current_user, :create_snippet, @project) - if can?(current_user, :create_snippet, @project)
%li %li
= link_to new_namespace_project_snippet_path(@project.namespace, @project) do = link_to new_namespace_project_snippet_path(@project.namespace, @project) do
Loading
Loading
Loading
@@ -6,9 +6,10 @@
Loading
@@ -6,9 +6,10 @@
.controls .controls
= render 'shared/issuable/search_form', path: namespace_project_merge_requests_path(@project.namespace, @project) = render 'shared/issuable/search_form', path: namespace_project_merge_requests_path(@project.namespace, @project)
   
- if can? current_user, :create_merge_request, @project - merge_project = can?(current_user, :create_merge_request, @project) ? @project : current_user.fork_of(@project)
- if merge_project
.pull-left.hidden-xs .pull-left.hidden-xs
= link_to new_namespace_project_merge_request_path(@project.namespace, @project), class: "btn btn-new", title: "New Merge Request" do = link_to new_namespace_project_merge_request_path(merge_project.namespace, merge_project), class: "btn btn-new", title: "New Merge Request" do
%i.fa.fa-plus %i.fa.fa-plus
New Merge Request New Merge Request
= render 'shared/issuable/filter', type: :merge_requests = render 'shared/issuable/filter', type: :merge_requests
Loading
Loading
@forks
Feature: Project Fork Feature: Project Fork
Background: Background:
Given I sign in as a user Given I sign in as a user
Loading
@@ -14,3 +15,12 @@ Feature: Project Fork
Loading
@@ -14,3 +15,12 @@ Feature: Project Fork
And I click link "Fork" And I click link "Fork"
When I fork to my namespace When I fork to my namespace
Then I should see a "Name has already been taken" warning Then I should see a "Name has already been taken" warning
Scenario: Merge request on canonical repo goes to fork merge request page
Given I click link "Fork"
And I fork to my namespace
Then I should see the forked project page
When I visit project "Shop" page
Then I should see "New merge request"
And I goto the Merge Requests page
Then I should see "New merge request"
Loading
@@ -30,4 +30,14 @@ class Spinach::Features::ProjectFork < Spinach::FeatureSteps
Loading
@@ -30,4 +30,14 @@ class Spinach::Features::ProjectFork < Spinach::FeatureSteps
click_link current_user.name click_link current_user.name
end end
end end
step 'I should see "New Merge Request"' do
expect(page).to have_content "New Merge Request"
end
step 'I goto the Merge Requests page' do
page.within '.page-sidebar-expanded' do
click_link "Merge Requests"
end
end
end end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment