Skip to content
Snippets Groups Projects
Commit 945e4293 authored by Tomasz Maczukin's avatar Tomasz Maczukin
Browse files

Prevent unnecessary forks iteration at parent update

parent 6f41e3d9
No related branches found
No related tags found
1 merge request!1744Fix/visibility level setting in forked projects
Loading
@@ -13,7 +13,7 @@ module Projects
Loading
@@ -13,7 +13,7 @@ module Projects
end end
   
return false unless visibility_level_allowed?(new_visibility) return false unless visibility_level_allowed?(new_visibility)
update_forks_visibility_level(new_visibility) update_forks_visibility_level(new_visibility.to_i)
end end
   
new_branch = params[:default_branch] new_branch = params[:default_branch]
Loading
@@ -44,11 +44,13 @@ module Projects
Loading
@@ -44,11 +44,13 @@ module Projects
end end
   
def update_forks_visibility_level(new_level) def update_forks_visibility_level(new_level)
return unless new_level < project.visibility_level
project.forks.each do |forked_project| project.forks.each do |forked_project|
fork_level = forked_project.visibility_level fork_level = forked_project.visibility_level
   
if fork_level > new_level.to_i if fork_level > new_level
forked_project.visibility_level = new_level.to_i forked_project.visibility_level = new_level
forked_project.save! forked_project.save!
end end
end end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment