Fixed create label form not working on issue boards in a sub-group project

Closes #31862

app/views/projects/boards/components/sidebar/_labels.html.haml

@@ -19,7 +19,7 @@
         ":value" => "label.id" }
       .dropdown
         %button.dropdown-menu-toggle.js-label-select.js-multiselect.js-issue-board-sidebar{ type: "button",
-          data: { toggle: "dropdown", field_name: "issue[label_names][]", show_no: "true", show_any: "true", project_id: @project.id, labels: namespace_project_labels_path(@project.namespace, @project, :json), namespace_path: @project.try(:namespace).try(:path), project_path: @project.try(:path) },
+          data: { toggle: "dropdown", field_name: "issue[label_names][]", show_no: "true", show_any: "true", project_id: @project.id, labels: namespace_project_labels_path(@project.namespace, @project, :json), namespace_path: @project.try(:namespace).try(:full_path), project_path: @project.try(:path) },
           ":data-issue-update" => "'#{namespace_project_issues_path(@project.namespace, @project)}/' + issue.id + '.json'" }
           %span.dropdown-toggle-text
             Label

changelogs/unreleased/issue-boards-sidebar-create-new-label-404-error.yml

+---
+title: Fixed create new label form in issue boards sidebar
+merge_request:
+author:

spec/features/boards/sub_group_project_spec.rb

+require 'rails_helper'
+
+describe 'Sub-group project issue boards', :feature, :js do
+  include WaitForVueResource
+
+  let(:group) { create(:group) }
+  let(:nested_group_1) { create(:group, parent: group) }
+  let(:project) { create(:empty_project, group: nested_group_1) }
+  let(:board) { create(:board, project: project) }
+  let(:label) { create(:label, project: project) }
+  let(:user) { create(:user) }
+  let!(:list1) { create(:list, board: board, label: label, position: 0) }
+  let!(:issue) { create(:labeled_issue, project: project, labels: [label]) }
+
+  before do
+    project.add_master(user)
+
+    login_as(user)
+
+    visit namespace_project_board_path(project.namespace, project, board)
+    wait_for_vue_resource
+  end
+
+  it 'creates new label from sidebar' do
+    find('.card').click
+
+    page.within '.labels' do
+      click_link 'Edit'
+      click_link 'Create new label'
+    end
+
+    page.within '.dropdown-new-label' do
+      fill_in 'new_label_name', with: 'test label'
+      first('.suggest-colors-dropdown a').click
+
+      click_button 'Create'
+
+      wait_for_ajax
+    end
+
+    page.within '.labels' do
+      expect(page).to have_link 'test label'
+    end
+  end
+end

[username-removed-581582]

@iamphill customer is still getting this issue. Please check the logs below.

==> /var/log/gitlab/gitlab-rails/production.log <== 
Started POST "/project_path/labels" for 90.109.131.233 at 2017-05-22 19:57:27 +0000

ActionController::RoutingError (No route matches [POST] "project_path"): 
  lib/gitlab/request_context.rb:18:in `call'

==> /var/log/gitlab/gitlab-workhorse/current <== 
2017-05-22_19:57:27.83743 2017/05/22 19:57:27 ErrorPage: serving predefined error page: 404 
2017-05-22_19:57:27.83787 project_domain @ - - [2017-05-22 19:57:27.799292199 +0000 UTC] "POST project_path/labels HTTP/1.1" 404 0 "http://project_url/issues/2/edit" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4" 0.038385

==> /var/log/gitlab/nginx/gitlab_error.log <== 
2017/05/22 19:57:27 [error] 6784#0: *1 upstream prematurely closed connection while reading upstream, client: 90.109.131.233, server: gitlab-domain, request: "POST /project_path/labels HTTP/1.1", upstream: "http://unix:/var/opt/gitlab/gitlab-workhorse/socket:/project_path/labels", host: "gitlab-domain", referrer: "project-url/edit"

==> /var/log/gitlab/nginx/gitlab_access.log <== 
90.109.131.233 - - [22/May/2017:19:57:27 +0000] "POST /project_path/labels HTTP/1.1" 404 20 "project_path/issues/2/edit" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4"

Things tried:

• change the browser from safari to chrome: same result (failed to create a label)
• create a brand new project in a subgroup and create a label from an issue: same result (failed to create a label)
• create a project on root (no subgroup) and create a label from an issue: worked

So at this point, I think the issue comes from using the subgroups. Let me know if you know about a temporary fix.

ZD: https://gitlab.zendesk.com/agent/tickets/76963

[Phil Hughes]

@arihantar Just tried this on GitLab.com & it seems to work fine