-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch 'guests_cant_see_mrs' into 'master'
Make guests unable to view MRs ## What does this MR do? Make guests unable to view MRs. This also fixes a bug when a non-member user could get notification if mentioned (in private project, it's OK for public project). Now if you are a guest and you will be mentioned in one of the MRs you won't get a notification. ## What are the relevant issue numbers? Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1410 See merge request !6673
No related branches found
No related tags found
Pipeline #
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/models/event.rb 7 additions, 1 deletionapp/models/event.rb
- app/policies/project_policy.rb 2 additions, 1 deletionapp/policies/project_policy.rb
- app/services/notification_service.rb 4 additions, 2 deletionsapp/services/notification_service.rb
- app/services/todo_service.rb 3 additions, 3 deletionsapp/services/todo_service.rb
- doc/user/permissions.md 1 addition, 0 deletionsdoc/user/permissions.md
- spec/features/projects/guest_navigation_menu_spec.rb 28 additions, 0 deletionsspec/features/projects/guest_navigation_menu_spec.rb
- spec/features/security/project/private_access_spec.rb 1 addition, 1 deletionspec/features/security/project/private_access_spec.rb
- spec/models/event_spec.rb 11 additions, 0 deletionsspec/models/event_spec.rb
- spec/policies/project_policy_spec.rb 3 additions, 2 deletionsspec/policies/project_policy_spec.rb
- spec/services/merge_requests/update_service_spec.rb 6 additions, 0 deletionsspec/services/merge_requests/update_service_spec.rb
- spec/services/notification_service_spec.rb 56 additions, 1 deletionspec/services/notification_service_spec.rb
- spec/services/todo_service_spec.rb 20 additions, 2 deletionsspec/services/todo_service_spec.rb
Loading
Please register or sign in to comment