Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce

app/controllers/application_controller.rb

@@ -45,6 +45,10 @@ class ApplicationController < ActionController::Base
     redirect_to request.referer.present? ? :back : default, options
   end
+  def not_found
+    render_404
+  end
+
   protected
   # This filter handles both private tokens and personal access tokens

config/routes.rb

@@ -88,4 +88,6 @@ Rails.application.routes.draw do
   get ':username.keys' => 'profiles/keys#get_keys', constraints: { username: /.*/ }
   root to: "root#index"
+
+  get '*unmatched_route', to: 'application#not_found'
 end

lib/extracts_path.rb

@@ -113,18 +113,19 @@ module ExtractsPath
     @id = get_id
     @ref, @path = extract_ref(@id)
     @repo = @project.repository
-    if @options[:extended_sha1].blank?
-      @commit = @repo.commit(@ref)
-    else
+
+    if @options[:extended_sha1].present?
       @commit = @repo.commit(@options[:extended_sha1])
-    end
-    if @path.empty? && !@commit
+    else
+      @commit = @repo.commit(@ref)
+      if @path.empty? && !@commit && @id.ends_with?('.atom')
         @id = @ref = extract_ref_without_atom(@id)
         @commit = @repo.commit(@ref)
         request.format = :atom if @commit
       end
+    end
     raise InvalidPathError unless @commit

spec/requests/git_http_spec.rb

@@ -412,9 +412,10 @@ describe 'Git HTTP requests', lib: true do
         context "when the params are anything else" do
           let(:params) { { service: 'git-implode-pack' } }
-          it "fails to find a route" do
-            expect { get(path, params) }.to raise_error(ActionController::RoutingError)
+          before { get path, params }
+          it "redirects to the sign-in page" do
+            expect(response).to redirect_to(new_user_session_path)
           end
         end
       end