Skip to content
Snippets Groups Projects
Commit a6ed18cc authored by Mike Greiling's avatar Mike Greiling
Browse files

remove superfluous return statements generated by coffeescript

parent 293eed4d
No related branches found
No related tags found
1 merge request!8031Resolve "Clicking markdown 'Preview' tab spawns two XHR requests"
Loading
@@ -22,14 +22,14 @@
Loading
@@ -22,14 +22,14 @@
mdText = form.find('textarea.markdown-area').val(); mdText = form.find('textarea.markdown-area').val();
if (mdText.trim().length === 0) { if (mdText.trim().length === 0) {
preview.text('Nothing to preview.'); preview.text('Nothing to preview.');
return this.hideReferencedUsers(form); this.hideReferencedUsers(form);
} else { } else {
preview.text('Loading...'); preview.text('Loading...');
return this.renderMarkdown(mdText, (function(_this) { this.renderMarkdown(mdText, (function(_this) {
return function(response) { return function(response) {
preview.html(response.body); preview.html(response.body);
preview.renderGFM(); preview.renderGFM();
return _this.renderReferencedUsers(response.references.users, form); _this.renderReferencedUsers(response.references.users, form);
}; };
})(this)); })(this));
} }
Loading
@@ -40,9 +40,10 @@
Loading
@@ -40,9 +40,10 @@
return; return;
} }
if (text === this.ajaxCache.text) { if (text === this.ajaxCache.text) {
return success(this.ajaxCache.response); success(this.ajaxCache.response);
return;
} }
return $.ajax({ $.ajax({
type: 'POST', type: 'POST',
url: window.preview_markdown_path, url: window.preview_markdown_path,
data: { data: {
Loading
@@ -55,16 +56,14 @@
Loading
@@ -55,16 +56,14 @@
text: text, text: text,
response: response response: response
}; };
return success(response); success(response);
}; };
})(this) })(this)
}); });
}; };
   
MarkdownPreview.prototype.hideReferencedUsers = function(form) { MarkdownPreview.prototype.hideReferencedUsers = function(form) {
var referencedUsers; form.find('.referenced-users').hide();
referencedUsers = form.find('.referenced-users');
return referencedUsers.hide();
}; };
   
MarkdownPreview.prototype.renderReferencedUsers = function(users, form) { MarkdownPreview.prototype.renderReferencedUsers = function(users, form) {
Loading
@@ -73,15 +72,14 @@
Loading
@@ -73,15 +72,14 @@
if (referencedUsers.length) { if (referencedUsers.length) {
if (users.length >= this.referenceThreshold) { if (users.length >= this.referenceThreshold) {
referencedUsers.show(); referencedUsers.show();
return referencedUsers.find('.js-referenced-users-count').text(users.length); referencedUsers.find('.js-referenced-users-count').text(users.length);
} else { } else {
return referencedUsers.hide(); referencedUsers.hide();
} }
} }
}; };
   
return MarkdownPreview; return MarkdownPreview;
})(); })();
   
markdownPreview = new window.MarkdownPreview(); markdownPreview = new window.MarkdownPreview();
Loading
@@ -93,15 +91,14 @@
Loading
@@ -93,15 +91,14 @@
lastTextareaPreviewed = null; lastTextareaPreviewed = null;
   
$.fn.setupMarkdownPreview = function() { $.fn.setupMarkdownPreview = function() {
var $form, form_textarea; var $form = $(this);
$form = $(this); $form.find('textarea.markdown-area')
form_textarea = $form.find('textarea.markdown-area'); .on('input', function() {
form_textarea.on('input', function() { markdownPreview.hideReferencedUsers($form);
return markdownPreview.hideReferencedUsers($form); })
}); .on('blur', function() {
return form_textarea.on('blur', function() { markdownPreview.showPreview($form);
return markdownPreview.showPreview($form); });
});
}; };
   
$(document).on('markdown-preview:show', function(e, $form) { $(document).on('markdown-preview:show', function(e, $form) {
Loading
@@ -115,7 +112,7 @@
Loading
@@ -115,7 +112,7 @@
// toggle content // toggle content
$form.find('.md-write-holder').hide(); $form.find('.md-write-holder').hide();
$form.find('.md-preview-holder').show(); $form.find('.md-preview-holder').show();
return markdownPreview.showPreview($form); markdownPreview.showPreview($form);
}); });
   
$(document).on('markdown-preview:hide', function(e, $form) { $(document).on('markdown-preview:hide', function(e, $form) {
Loading
@@ -129,7 +126,7 @@
Loading
@@ -129,7 +126,7 @@
// toggle content // toggle content
$form.find('.md-write-holder').show(); $form.find('.md-write-holder').show();
$form.find('textarea.markdown-area').focus(); $form.find('textarea.markdown-area').focus();
return $form.find('.md-preview-holder').hide(); $form.find('.md-preview-holder').hide();
}); });
   
$(document).on('markdown-preview:toggle', function(e, keyboardEvent) { $(document).on('markdown-preview:toggle', function(e, keyboardEvent) {
Loading
@@ -137,11 +134,11 @@
Loading
@@ -137,11 +134,11 @@
$target = $(keyboardEvent.target); $target = $(keyboardEvent.target);
if ($target.is('textarea.markdown-area')) { if ($target.is('textarea.markdown-area')) {
$(document).triggerHandler('markdown-preview:show', [$target.closest('form')]); $(document).triggerHandler('markdown-preview:show', [$target.closest('form')]);
return keyboardEvent.preventDefault(); keyboardEvent.preventDefault();
} else if (lastTextareaPreviewed) { } else if (lastTextareaPreviewed) {
$target = lastTextareaPreviewed; $target = lastTextareaPreviewed;
$(document).triggerHandler('markdown-preview:hide', [$target.closest('form')]); $(document).triggerHandler('markdown-preview:hide', [$target.closest('form')]);
return keyboardEvent.preventDefault(); keyboardEvent.preventDefault();
} }
}); });
   
Loading
@@ -149,14 +146,14 @@
Loading
@@ -149,14 +146,14 @@
var $form; var $form;
e.preventDefault(); e.preventDefault();
$form = $(this).closest('form'); $form = $(this).closest('form');
return $(document).triggerHandler('markdown-preview:show', [$form]); $(document).triggerHandler('markdown-preview:show', [$form]);
}); });
   
$(document).on('click', writeButtonSelector, function(e) { $(document).on('click', writeButtonSelector, function(e) {
var $form; var $form;
e.preventDefault(); e.preventDefault();
$form = $(this).closest('form'); $form = $(this).closest('form');
return $(document).triggerHandler('markdown-preview:hide', [$form]); $(document).triggerHandler('markdown-preview:hide', [$form]);
}); });
   
}).call(this); }).call(this);
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment