-
- Downloads
Fix ordering of commits in the network graph.
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1 - Prior to this upgrade, the default sort order for commits returned by `Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the graph relied on. - While upgrading `rugged`, the MR also changed this default to `Rugged::SORT_NONE`, which broke commit ordering in the graph. - This commit adds an option to `Gitlab::Git::Repository#find_commits` to sort by date, and changes the graph builder `Network::Graph` so it explictly requests the `:date` sort order
Showing
- app/models/network/graph.rb 2 additions, 1 deletionapp/models/network/graph.rb
- lib/gitlab/git/repository.rb 17 additions, 6 deletionslib/gitlab/git/repository.rb
- spec/lib/gitlab/git/repository_spec.rb 29 additions, 0 deletionsspec/lib/gitlab/git/repository_spec.rb
- spec/models/network/graph_spec.rb 21 additions, 0 deletionsspec/models/network/graph_spec.rb
Loading
Please register or sign in to comment