Ruby fixes

b5ece088 · Phil Hughes · 35b3c709 · b5ece088 · b5ece088
Commit b5ece088 authored 9 years ago by Phil Hughes
--- a/app/helpers/issuables_helper.rb
+++ b/app/helpers/issuables_helper.rb
@@ -48,18 +48,11 @@ module IssuablesHelper
  end
  def milestone_dropdown_label(milestone_title, default_label)
-    milestone_title =
    if milestone_title == Milestone::Upcoming.name
-        Milestone::Upcoming.title
+      milestone_title = Milestone::Upcoming.title
-      else
-        milestone_title
    end
-    if !milestone_title.nil? && !milestone_title.empty?
+    h(milestone_title.presence || default_label)
-      h(milestone_title)
-    else
-      default_label
-    end
  end
  private

--- a/app/models/global_milestone.rb
+++ b/app/models/global_milestone.rb