Add DSL for adding nodes in Ci config interface

lib/gitlab/ci/config/node/before_script.rb

@@ -5,10 +5,6 @@ module Gitlab
         class BeforeScript < Entry
           include ValidationHelpers
-          def keys
-            {}
-          end
-
           def validate!
             unless validate_array_of_strings(@value)
               @errors << 'before_script should be an array of strings'

lib/gitlab/ci/config/node/entry.rb

@@ -48,12 +48,22 @@ module Gitlab
           end
           def keys
-            raise NotImplementedError
+            self.class.nodes || {}
           end
           def validate!
             raise NotImplementedError
           end
+
+          class << self
+            attr_reader :nodes
+
+            private
+
+            def add_node(symbol, entry_class)
+              (@nodes ||= {}).merge!(symbol.to_sym => entry_class)
+            end
+          end
         end
       end
     end

lib/gitlab/ci/config/node/global.rb

@@ -3,9 +3,7 @@ module Gitlab
     class Config
       module Node
         class Global < Entry
-          def keys
-            { before_script: BeforeScript }
-          end
+          add_node :before_script, BeforeScript
         end
       end
     end

lib/gitlab/ci/config/node/null.rb

@@ -3,10 +3,6 @@ module Gitlab
     class Config
       module Node
         class Null < Entry
-          def keys
-            {}
-          end
-
           def method_missing(*)
             nil
           end

spec/lib/gitlab/ci/config/node/global_spec.rb

@@ -7,6 +7,10 @@ describe Gitlab::Ci::Config::Node::Global do
     it 'can contain global config keys' do
       expect(global.keys).to include :before_script
     end
+
+    it 'returns a hash' do
+      expect(global.keys).to be_a Hash
+    end
   end
   context 'when hash is valid' do