Skip to content
Snippets Groups Projects
Commit c3c92c73 authored by Rubén Dávila's avatar Rubén Dávila
Browse files

Make default sorting preference work for Issues and MRs.

parent 9ef46892
No related branches found
No related tags found
1 merge request!2537Save list sort in a cookie
Pipeline #
Loading
@@ -410,10 +410,8 @@ class ApplicationController < ActionController::Base
Loading
@@ -410,10 +410,8 @@ class ApplicationController < ActionController::Base
private private
   
def set_default_sort def set_default_sort
key = if is_a_listing_page_for?('issues') key = if is_a_listing_page_for?('issues') || is_a_listing_page_for?('merge_requests')
'issues_sort' 'issuable_sort'
elsif is_a_listing_page_for?('merge_requests')
'merge_requests_sort'
end end
   
cookies[key] = params[:sort] if key && params[:sort].present? cookies[key] = params[:sort] if key && params[:sort].present?
Loading
Loading
Loading
@@ -67,6 +67,13 @@ Feature: Project Issues
Loading
@@ -67,6 +67,13 @@ Feature: Project Issues
And I visit project "Shop" issues page And I visit project "Shop" issues page
Then The list should be sorted by "Oldest updated" Then The list should be sorted by "Oldest updated"
   
@javascript
Scenario: Visiting Merge Requests after being sorted the list
Given I visit project "Shop" issues page
And I sort the list by "Oldest updated"
And I visit project "Shop" merge requests page
Then The list should be sorted by "Oldest updated"
@javascript @javascript
Scenario: Visiting Merge Requests from a differente Project after sorting Scenario: Visiting Merge Requests from a differente Project after sorting
Given I visit project "Shop" merge requests page Given I visit project "Shop" merge requests page
Loading
Loading
Loading
@@ -92,6 +92,13 @@ Feature: Project Merge Requests
Loading
@@ -92,6 +92,13 @@ Feature: Project Merge Requests
And I visit project "Shop" merge requests page And I visit project "Shop" merge requests page
Then The list should be sorted by "Oldest updated" Then The list should be sorted by "Oldest updated"
   
@javascript
Scenario: Visiting Issues after being sorted the list
Given I visit project "Shop" merge requests page
And I sort the list by "Oldest updated"
And I visit project "Shop" issues page
Then The list should be sorted by "Oldest updated"
@javascript @javascript
Scenario: Visiting Merge Requests from a differente Project after sorting Scenario: Visiting Merge Requests from a differente Project after sorting
Given I visit project "Shop" merge requests page Given I visit project "Shop" merge requests page
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment