-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch 'you-get-a-title-and-you-get-a-title-and-everyone-gets-a-title' into 'master'
Add a page title to every page.  The `page_title` helper pushes the provided string at the end of the title, but because of the order that layouts are rendered in by ActionView, the result is always this: ``` <title from view> | <title from as specified in the controller or by its layout> | <title from layouts/_head> ``` For example: `Merge Requests | GitLab.org / Gitlab Community Edition | GitLab`. All a developer needs to know is to put a `page_title` call describing the page in question at the start of every template. To get everything where I wanted it to go without too much duplication, I had to make some changes around layouts, sidebars and controllers. See merge request !593
Showing
- .gitignore 1 addition, 1 deletion.gitignore
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/assets/javascripts/dispatcher.js.coffee 0 additions, 1 deletionapp/assets/javascripts/dispatcher.js.coffee
- app/controllers/admin/application_controller.rb 1 addition, 1 deletionapp/controllers/admin/application_controller.rb
- app/controllers/application_controller.rb 1 addition, 0 deletionsapp/controllers/application_controller.rb
- app/controllers/dashboard/application_controller.rb 3 additions, 0 deletionsapp/controllers/dashboard/application_controller.rb
- app/controllers/dashboard/groups_controller.rb 1 addition, 1 deletionapp/controllers/dashboard/groups_controller.rb
- app/controllers/dashboard/milestones_controller.rb 1 addition, 1 deletionapp/controllers/dashboard/milestones_controller.rb
- app/controllers/dashboard/projects_controller.rb 1 addition, 1 deletionapp/controllers/dashboard/projects_controller.rb
- app/controllers/dashboard_controller.rb 3 additions, 3 deletionsapp/controllers/dashboard_controller.rb
- app/controllers/explore/application_controller.rb 3 additions, 0 deletionsapp/controllers/explore/application_controller.rb
- app/controllers/explore/groups_controller.rb 1 addition, 3 deletionsapp/controllers/explore/groups_controller.rb
- app/controllers/explore/projects_controller.rb 1 addition, 3 deletionsapp/controllers/explore/projects_controller.rb
- app/controllers/groups/application_controller.rb 1 addition, 8 deletionsapp/controllers/groups/application_controller.rb
- app/controllers/groups/avatars_controller.rb 0 additions, 2 deletionsapp/controllers/groups/avatars_controller.rb
- app/controllers/groups/group_members_controller.rb 0 additions, 2 deletionsapp/controllers/groups/group_members_controller.rb
- app/controllers/groups/milestones_controller.rb 1 addition, 3 deletionsapp/controllers/groups/milestones_controller.rb
- app/controllers/groups_controller.rb 2 additions, 9 deletionsapp/controllers/groups_controller.rb
- app/controllers/help_controller.rb 6 additions, 4 deletionsapp/controllers/help_controller.rb
- app/controllers/invites_controller.rb 0 additions, 2 deletionsapp/controllers/invites_controller.rb
Loading
Please register or sign in to comment