Merge branch 'refactoring/context_into_services' into 'master'

Refactoring context Into services

To prevent confusion where to write logic. Context or Service?

app/controllers/admin/projects_controller.rb

@@ -19,7 +19,7 @@ class Admin::ProjectsController < Admin::ApplicationController
   end
   def transfer
-    result = ::Projects::TransferContext.new(@project, current_user, project: params).execute(:admin)
+    result = ::Projects::TransferService.new(@project, current_user, project: params).execute(:admin)
     if result
       redirect_to [:admin, @project]

app/controllers/projects/blob_controller.rb

@@ -13,7 +13,7 @@ class Projects::BlobController < Projects::ApplicationController
   end
   def destroy
-    result = Files::DeleteContext.new(@project, current_user, params, @ref, @path).execute
+    result = Files::DeleteService.new(@project, current_user, params, @ref, @path).execute
     if result[:status] == :success
       flash[:notice] = "Your changes have been successfully committed"

app/controllers/projects/edit_tree_controller.rb

@@ -7,7 +7,7 @@ class Projects::EditTreeController < Projects::BaseTreeController
   end
   def update
-    result = Files::UpdateContext.new(@project, current_user, params, @ref, @path).execute
+    result = Files::UpdateService.new(@project, current_user, params, @ref, @path).execute
     if result[:status] == :success
       flash[:notice] = "Your changes have been successfully committed"

app/controllers/projects/issues_controller.rb

@@ -89,7 +89,7 @@ class Projects::IssuesController < Projects::ApplicationController
   end
   def bulk_update
-    result = Issues::BulkUpdateContext.new(project, current_user, params).execute
+    result = Issues::BulkUpdateService.new(project, current_user, params).execute
     redirect_to :back, notice: "#{result[:count]} issues updated"
   end

app/controllers/projects/new_tree_controller.rb

@@ -6,7 +6,7 @@ class Projects::NewTreeController < Projects::BaseTreeController
   def update
     file_path = File.join(@path, File.basename(params[:file_name]))
-    result = Files::CreateContext.new(@project, current_user, params, @ref, file_path).execute
+    result = Files::CreateService.new(@project, current_user, params, @ref, file_path).execute
     if result[:status] == :success
       flash[:notice] = "Your changes have been successfully committed"

app/controllers/projects/notes_controller.rb

@@ -5,7 +5,7 @@ class Projects::NotesController < Projects::ApplicationController
   before_filter :authorize_admin_note!, only: [:update, :destroy]
   def index
-    @notes = Notes::LoadContext.new(project, current_user, params).execute
+    @notes = Notes::LoadService.new(project, current_user, params).execute
     notes_json = { notes: [] }
@@ -20,7 +20,7 @@ class Projects::NotesController < Projects::ApplicationController
   end
   def create
-    @note = Notes::CreateContext.new(project, current_user, params).execute
+    @note = Notes::CreateService.new(project, current_user, params).execute
     respond_to do |format|
       format.json { render_note_json(@note) }

app/controllers/projects_controller.rb

@@ -20,7 +20,7 @@ class ProjectsController < ApplicationController
   end
   def create
-    @project = ::Projects::CreateContext.new(current_user, params[:project]).execute
+    @project = ::Projects::CreateService.new(current_user, params[:project]).execute
     respond_to do |format|
       flash[:notice] = 'Project was successfully created.' if @project.saved?
@@ -36,7 +36,7 @@ class ProjectsController < ApplicationController
   end
   def update
-    status = ::Projects::UpdateContext.new(@project, current_user, params).execute
+    status = ::Projects::UpdateService.new(@project, current_user, params).execute
     respond_to do |format|
       if status
@@ -51,7 +51,7 @@ class ProjectsController < ApplicationController
   end
   def transfer
-    ::Projects::TransferContext.new(project, current_user, params).execute
+    ::Projects::TransferService.new(project, current_user, params).execute
   end
   def show
@@ -89,7 +89,7 @@ class ProjectsController < ApplicationController
   end
   def fork
-    @forked_project = ::Projects::ForkContext.new(project, current_user).execute
+    @forked_project = ::Projects::ForkService.new(project, current_user).execute
     respond_to do |format|
       format.html do

app/controllers/search_controller.rb

@@ -5,9 +5,9 @@ class SearchController < ApplicationController
     if @project
       return access_denied! unless can?(current_user, :download_code, @project)
-      @search_results = Search::ProjectContext.new(@project, current_user, params).execute
+      @search_results = Search::ProjectService.new(@project, current_user, params).execute
     else
-      @search_results = Search::GlobalContext.new(current_user, params).execute
+      @search_results = Search::GlobalService.new(current_user, params).execute
     end
   end
 end

app/contexts/base_context.rb → app/services/base_service.rb

-class BaseContext
+class BaseService
   attr_accessor :project, :current_user, :params
   def initialize(project, user, params)

app/contexts/files/base_context.rb → app/services/files/base_service.rb

 module Files
-  class BaseContext < ::BaseContext
+  class BaseService < ::BaseService
     attr_reader :ref, :path
     def initialize(project, user, params, ref, path = nil)

app/contexts/files/create_context.rb → app/services/files/create_service.rb

-require_relative "base_context"
+require_relative "base_service"
 module Files
-  class CreateContext < BaseContext
+  class CreateService < BaseService
     def execute
       allowed = if project.protected_branch?(ref)
                   can?(current_user, :push_code_to_protected_branches, project)

app/contexts/files/delete_context.rb → app/services/files/delete_service.rb

-require_relative "base_context"
+require_relative "base_service"
 module Files
-  class DeleteContext < BaseContext
+  class DeleteService < BaseService
     def execute
       allowed = if project.protected_branch?(ref)
                   can?(current_user, :push_code_to_protected_branches, project)

app/contexts/files/update_context.rb → app/services/files/update_service.rb

-require_relative "base_context"
+require_relative "base_service"
 module Files
-  class UpdateContext < BaseContext
+  class UpdateService < BaseService
     def execute
       allowed = if project.protected_branch?(ref)
                   can?(current_user, :push_code_to_protected_branches, project)

app/contexts/issues/bulk_update_context.rb → app/services/issues/bulk_update_service.rb

 module Issues
-  class BulkUpdateContext < BaseContext
+  class BulkUpdateService < BaseService
     def execute
       update_data = params[:update]

app/contexts/notes/create_context.rb → app/services/notes/create_service.rb

 module Notes
-  class CreateContext < BaseContext
+  class CreateService < BaseService
     def execute
       note = project.notes.new(params[:note])
       note.author = current_user

app/contexts/notes/load_context.rb → app/services/notes/load_service.rb

 module Notes
-  class LoadContext < BaseContext
+  class LoadService < BaseService
     def execute
       target_type = params[:target_type]
       target_id   = params[:target_id]

app/contexts/projects/create_context.rb → app/services/projects/create_service.rb

 module Projects
-  class CreateContext < BaseContext
+  class CreateService < BaseService
     def initialize(user, params)
       @current_user, @params = user, params.dup
     end

app/contexts/projects/fork_context.rb → app/services/projects/fork_service.rb

 module Projects
-  class ForkContext < BaseContext
+  class ForkService < BaseService
     include Gitlab::ShellAdapter
     def initialize(project, user)

app/contexts/projects/transfer_context.rb → app/services/projects/transfer_service.rb

 module Projects
-  class TransferContext < BaseContext
+  class TransferService < BaseService
     def execute(role = :default)
       namespace_id = params[:project].delete(:namespace_id)
       allowed_transfer = can?(current_user, :change_namespace, project) || role == :admin

app/contexts/projects/update_context.rb → app/services/projects/update_service.rb

 module Projects
-  class UpdateContext < BaseContext
+  class UpdateService < BaseService
     def execute(role = :default)
       params[:project].delete(:namespace_id)
       # check that user is allowed to set specified visibility_level