-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch '13948-access-request-to-projects-and-groups' into 'master'
Allow users to request access to projects and groups #### TODO: - [x] Factorize the projects & groups members list - [x] Factorize `request_access` and `approve` controller methods into a concern - [x] Factorize the project & group dropdowns - [x] Factorize access request routes - [x] Factorize mailers #### Will be done in separate MRs - [ ] Documentation - [ ] API #### Access request to project - [x] Design project access request button to spec (defined in #13948) - [x] Request access to a project as a logged in user - [x] Withdraw access request to a project as a logged in user - [x] Do not treat project member request as actual membership (done partly in Ability) - [x] Display access requests on project's members page (+ allow to change level, approve, and deny request) - [x] Email requesting user at notification email address when accepted/denied - [x] Email all project admins at notification email addresses when new access request - [x] Unit specs to cover new functionality: `AccessRequestable` is missing specs - [x] Controller specs to cover new functionality - [x] Mailer specs to cover new functionality - [x] Features specs to cover new UI and interactions - [x] Regression specs still passing #### Access request to group - [x] Design group access request button to spec (defined in #13948) - [x] Request access to a group as a logged in user - [x] Withdraw access request to a group as a logged in user - [x] Do not treat group member request as actual membership - [x] Display access requests on group's members page (+ allow to change level, approve, and deny request) - [x] Email requesting user at notification email address when accepted/denied - [x] Email all project admins at notification email addresses when new access request - [x] Unit specs to cover new functionality - [x] Controller specs to cover new functionality - [x] Mailer specs to cover new functionality - [x] Features specs to cover new UI and interactions - [x] Regression specs still passing Closes #13948. ### Requesting access to a project #### Responsive UI  #### Request access link  #### Flash once access is requested  #### Email sent to project admins on new access requests ##### HTML Email  ##### Plain Email  ### Withdrawing access request to a project #### Withdraw access request link  #### Withdraw access request confirmation dialog box  #### Flash once access has been withdrawn  ### Access requests management page  #### Deny access request confirmation dialog box  #### Email sent to requester on denied access requests ##### HTML Email  ##### Plain Email  #### Email sent to requester on granted access requests ##### HTML Email  ##### Plain Email  ---------------------------------- ---------------------------------- ### Requesting access to a group #### Responsive UI  #### Request access link  #### Flash once access is requested  #### Email sent to project admins on new access requests ##### HTML Email  ##### Plain Email  ### Withdrawing access request to a project #### Withdraw access request link  #### Withdraw access request confirmation dialog box  #### Flash once access has been withdrawn  ### Access requests management page  #### Deny access request confirmation dialog box  #### Email sent to requester on denied access requests ##### HTML Email  ##### Plain Email  #### Email sent to requester on granted access requests ##### HTML Email  ##### Plain Email  See merge request !3798
Showing
- app/assets/stylesheets/pages/groups.scss 17 additions, 0 deletionsapp/assets/stylesheets/pages/groups.scss
- app/assets/stylesheets/pages/projects.scss 12 additions, 9 deletionsapp/assets/stylesheets/pages/projects.scss
- app/controllers/concerns/membership_actions.rb 58 additions, 0 deletionsapp/controllers/concerns/membership_actions.rb
- app/controllers/groups/group_members_controller.rb 11 additions, 18 deletionsapp/controllers/groups/group_members_controller.rb
- app/controllers/projects/project_members_controller.rb 13 additions, 23 deletionsapp/controllers/projects/project_members_controller.rb
- app/helpers/gitlab_routing_helper.rb 65 additions, 12 deletionsapp/helpers/gitlab_routing_helper.rb
- app/helpers/groups_helper.rb 0 additions, 20 deletionsapp/helpers/groups_helper.rb
- app/helpers/members_helper.rb 45 additions, 0 deletionsapp/helpers/members_helper.rb
- app/helpers/projects_helper.rb 0 additions, 20 deletionsapp/helpers/projects_helper.rb
- app/mailers/emails/groups.rb 0 additions, 52 deletionsapp/mailers/emails/groups.rb
- app/mailers/emails/members.rb 81 additions, 0 deletionsapp/mailers/emails/members.rb
- app/mailers/emails/projects.rb 0 additions, 50 deletionsapp/mailers/emails/projects.rb
- app/mailers/notify.rb 3 additions, 1 deletionapp/mailers/notify.rb
- app/models/ability.rb 2 additions, 0 deletionsapp/models/ability.rb
- app/models/concerns/access_requestable.rb 16 additions, 0 deletionsapp/models/concerns/access_requestable.rb
- app/models/group.rb 6 additions, 1 deletionapp/models/group.rb
- app/models/member.rb 47 additions, 6 deletionsapp/models/member.rb
- app/models/members/group_member.rb 17 additions, 3 deletionsapp/models/members/group_member.rb
- app/models/members/project_member.rb 13 additions, 3 deletionsapp/models/members/project_member.rb
- app/models/project.rb 5 additions, 12 deletionsapp/models/project.rb
Loading
Please register or sign in to comment