Invalid raw commit type

7.9.0.rc1

ActionView::Template::Error (Invalid raw commit type: Rugged::Blob):
    23:   - if commit.description?
    24:     .commit-row-description.js-toggle-content
    25:       %pre
    26:         = preserve(gfm(escape_once(commit.description)))
    27:
    28:   .commit-row-info
    29:     = commit_author_link(commit, avatar: true, size: 24)
  app/models/repository.rb:30:in `commit'
  lib/gitlab/markdown.rb:295:in `reference_commit'
  lib/gitlab/markdown.rb:212:in `reference_link'
  lib/gitlab/markdown.rb:190:in `parse_result'
  lib/gitlab/markdown.rb:173:in `block in parse_references'
  lib/gitlab/markdown.rb:162:in `gsub!'
  lib/gitlab/markdown.rb:162:in `parse_references'
  lib/gitlab/markdown.rb:134:in `parse'
  lib/gitlab/markdown.rb:73:in `gfm_with_options'
  lib/gitlab/markdown.rb:43:in `gfm'
  app/views/projects/commits/_commit.html.haml:26:in `_app_views_projects_commits__commit_html_haml___3349596888153175499_112953920'
  app/views/projects/commits/_commits.html.haml:14:in `block in _app_views_projects_commits__commits_html_haml__3759418747933461966_112621300'
  app/views/projects/commits/_commits.html.haml:4:in `each'
  app/views/projects/commits/_commits.html.haml:4:in `_app_views_projects_commits__commits_html_haml__3759418747933461966_112621300'
  app/views/projects/commits/show.html.haml:16:in `_app_views_projects_commits_show_html_haml__2714336405425623338_31087160'
  app/controllers/projects/commits_controller.rb:18:in `show'
  lib/gitlab/middleware/timeout.rb:9:in `call'

cc @haynes

mentioned in issue #1241 (closed)

I can't reproduce on 7-9-stable or master.

It is supposed to have been fixed in https://gitlab.com/gitlab-org/gitlab_git/commit/108cb66356602f6407cfd65811569f3e0594b77d, which is in gitlab_git 7.1.1 which is indeed in gitlab 7.9.0rc1.

@marin Do you have an example of a URL where this error occurs?

@DouweM https://gitlab.com/HelmutT/linux-kernel-test/commits/master

So this commit seems to be the culprit: https://gitlab.com/HelmutT/linux-kernel-test/commit/71a59b12727316f6d3c1cf4335bc2eaecb86da25 (https://github.com/torvalds/linux/commit/71a59b12727316f6d3c1cf4335bc2eaecb86da25)

But I don't see anything sha-like in that message, so I'm confused:

Merge tag 'armsoc-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

Pull ARM SoC fixes from Olof Johansson:
 "A week's worth of fixes for various ARM platforms.  Diff wise, the
  largest fix is for OMAP to deal with how GIC now registers interrupts
  (irq_domain_add_legacy() -> irq_domain_add_linear() changes).

  Besides this, a few more renesas platforms needed the GIC instatiation
  done for legacy boards.  There's also a fix that disables coherency of
  mvebu due to issues, and a few other smaller fixes"

* tag 'armsoc-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc:
  arm64: dts: add baud rate to Juno stdout-path
  ARM: dts: imx25: Fix PWM "per" clocks
  bus: mvebu-mbus: fix support of MBus window 13
  Merge tag 'mvebu-fixes-3.19-3' of git://git.infradead.org/linux-mvebu into fixes
  ARM: mvebu: completely disable hardware I/O coherency
  ARM: OMAP: Work around hardcoded interrupts
  ARM: shmobile: r8a7779: Instantiate GIC from C board code in legacy builds
  ARM: shmobile: r8a7778: Instantiate GIC from C board code in legacy builds
  arm: boot: dts: dra7: enable dwc3 suspend PHY quirk

@marin Can you check the logs for that commit specifically and see if it is indeed the same error?

@DouweM It is the same as in description.

The issue is 8a7778, which is apparently the id for a blob in that repo. No idea yet why it isn't caught by the mentioned gitlab_git fix.

(Note that 8a7778 is directly preceded by an r, so it really shouldn't be interpreted as a commit hash at all)

@DouweM rc1 didn't pull the current gitlab_git with the fix.
https://gitlab.com/gitlab-org/gitlab-ce/blob/v7.9.0.rc1/Gemfile#L42

edit: nevermind. I didn't understand the Gemfile versioning

Yep, it's definitely in gemfile.lock.

@DouweM @haynes: @dzaporozhets and I found it. Problem was with the merge between ce and ee which didn't update the gemfile.lock correctly. RC2 will have the correct gitlab_git version.

@marin great!

Fixed in RC2.

Status changed to closed

mentioned in merge request !14785