unreasonable things happened after company-wide email change

omnibus-gitlab 7.5.3 with LDAP as the only authenticate method.

my company changed its email address from 'name.surname@abc.com' to 'name.surname@xyz.com', what happened:

1. every old user required to confirm their email address to 'xxx@xyz.com', this step seems OK. But their email remains to the old one, '@abc.com', didn't update to '@xyz.com'
2. username changes automatically from uid to the prefix of email address, e.g. from 'neox' to 'neo.smith', it causes '@neox' failed in comment/issue pages.
3. since some users have created several projects under their username, I don't know what would happen to those projects
4. I tried to update it to old uniq uid, but failed both on admin web page or by console (this can be ignored):

gitlab-rails :005 > user.username = 'neox'
 => "neox"
gitlab-rails :006 > user.save
Exception: namespace directory cannot be moved
        from /opt/gitlab/embedded/service/gitlab-rails/app/models/namespace.rb:82:in `move_dir'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:424:in `block in make_lambda'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:221:in `call'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:221:in `block in halting_and_conditional'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:86:in `call'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:86:in `run_callbacks'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/callbacks.rb:310:in `update_record'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/timestamp.rb:70:in `update_record'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/persistence.rb:482:in `create_or_update'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/callbacks.rb:302:in `block in create_or_update'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:113:in `call'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:113:in `call'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:166:in `block in halting'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:166:in `call'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:166:in `block in halting'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.1.1/lib/active_support/callbacks.rb:86:in `call'
... 54 levels...
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/state_machine-1.2.0/lib/state_machine/integrations/active_record.rb:530:in `block in transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:211:in `block in transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:219:in `within_new_transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:211:in `transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.1.1/lib/active_record/transactions.rb:208:in `transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/state_machine-1.2.0/lib/state_machine/integrations/active_record.rb:529:in `transaction'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/state_machine-1.2.0/lib/state_machine/integrations/active_record.rb:501:in `around_save'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/state_machine-1.2.0/lib/state_machine/integrations/active_record.rb:483:in `save'
        from (irb):6
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/railties-4.1.1/lib/rails/commands/console.rb:90:in `start'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/railties-4.1.1/lib/rails/commands/console.rb:9:in `start'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:69:in `console'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:40:in `run_command!'
        from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/railties-4.1.1/lib/rails/commands.rb:17:in `<top (required)>'
        from bin/rails:8

It said namespace can't move, but there is no project under 'neox/'

Added ~12980 ldap labels

expected result: after company-wide changed email ('abc.com' to 'xyz.com'), when an old user login, he/she can login as normal, gitlab should update its email accordingly, keep username no touched (since uid is not change, only email address changed in this case).

current implementation seems treat email address as the unique id to distinguish users but not 'extern_uid', it's incorrect in LDAP environment I think. It changes username but keep the emails address as the old one, which is very wrong.

mentioned in issue #993 (closed)

Upgraded to omnibus 7.9.1 ce, problems remained:

1. But their emails remained the old one, '@abc.com', didn't update to '@xyz.com'

added ~480950 needs investigation labels

moved to gitlab#3723

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue

mentioned in merge request !14785