Markdown markup within a link is improperly escaped

Summary

If you use Markdown markup in the body of a Markdown-style link, that markup is rendered to HTML and then escaped, which results in the HTML being shown as text to the user. For example, the user will see a link with the text "<em>foo</em>" instead of a link with the text "foo" in italics.

Steps to reproduce

Create a Markdown file, snippet, issue description, or comment with the following Markdown code:

* [_foo_](http://gitlab.com)
* [*foo*](http://gitlab.com)
* [**foo**](http://gitlab.com)
* [`foo`](http://gitlab.com)

Expected behavior

The above Markdown should be rendered to the following HTML:

<ul>
<li><a href="http://gitlab.com"><em>foo</em></a></li>
<li><a href="http://gitlab.com"><em>foo</em></a></li>
<li><a href="http://gitlab.com"><strong>foo</strong></a></li>
<li><a href="http://gitlab.com"><code>foo</code></a></li>
</ul>

Observed behavior

(Tested on Gitlab.com itself on 2015-03-30.)

The above Markdown is rendered to the following (incorrect) HTML:

<ul>
<li><a href="http://gitlab.com">&lt;em&gt;foo&lt;/em&gt;</a></li>
<li><a href="http://gitlab.com">&lt;em&gt;foo&lt;/em&gt;</a></li>
<li><a href="http://gitlab.com">&lt;strong&gt;foo&lt;/strong&gt;</a></li>
<li><a href="http://gitlab.com">&lt;code&gt;foo&lt;/code&gt;</a></li>
</ul>

Live example:

• foo
• foo
• foo
• foo

You can also see this issue affecting a rendered Markdown file at: https://gitlab.com/cloje/cloje/blob/4a3a4fb5/docs/exports.md

Possible fixes

The markup inside the link body should be rendered to HTML, but not subsequently escaped.

Also #1221 (closed)

@rspeicher Does your markdown refactoring fixes this?

@razer6 I believe this is similar to #1553 (closed), in which case, no. It's on my list!

I stand corrected, the Markdown refactoring did fix it.

It'll be in the next release. Thanks @jcroisant for the report.

Reassigned to @rspeicher

Milestone changed to 7.11

Status changed to closed

mentioned in merge request !619 (merged)