404 on Wiki pages that include a '/'

Example here:

https://gitlab.ecosystem-modelling.pml.ac.uk/sha/gitlab-forward-slash-issue/wikis/Test/subgroup1

Click on Page History and you get a 404 error.

Source code shows that the link is pointing to /sha/gitlab-forward-slash-issue/wikis/Test%2Fsubgroup1/history instead of the expected /sha/gitlab-forward-slash-issue/wikis/Test/subgroup1/history.

This has worked in previous versions.

Example wiki page to reproduce:

Home:

* [Test](Test) - Group Heading
    * [Test Subgroup](Test/subgroup1)

GitLab 7.9.1 6f6c5f18

Pages inside folders cannot be neither edited nor updated since every time I try to access or update the page, '/' are encoded to '%2F' and thus any action results in 404. When searching for a page, link on search result is broken (encoded) as well. The above worked in previous version. Looks like improved support for utf8 introduced in 7.9 may be relevant to those issues.

Discussed here as well:

https://github.com/gitlabhq/gitlabhq/issues/9022

I've been trying to fix this issue, but it's a bit of pain. The bottom-line is that in Rails v4.1.9+, model IDs are automatically escaped when the default URL helpers are used. There's no way to disable this, as far as I can tell. That means either:

1. Adapt the routes.db to allow resolution for %2F.
2. Change all routes to direct to a manually-created URL.
3. Disable support for paths in Wiki pages entirely.

Option 1 is the easiest, but it results in very ugly URLs.

Option 2 is ideal because it keeps the URL structure in place, but when I tried to implement it, I found that there are a lot of places which rely on the default Rails URL generators for CRUD operations. We would have to switch them all out, and it may be confusing down the road.

What are your thoughts, @DouweM?

@stanhu How hard would it be to override namespace_project_wiki_path to construct the URL "manually", so with / instead of %2F?

So which lines in routes.rb would I need to modify for Option 1 as a work around? I'm thinking 161 and 274, but not sure.

From a quick look that'd be 372, actually.

Thanks, @DouweM, it looks like overriding namespace_project_wiki_path works. I've got a fix I'm testing now.

mentioned in merge request !502 (merged)

Ok, phew, finally got this to work. See !502 (merged). @DouweM, can you review? Thanks.

Status changed to closed by commit 3143edfe

mentioned in commit f3f85602

mentioned in merge request !505 (merged)

mentioned in issue #1399 (closed)

mentioned in merge request !14785