Make sure notification email footer correctly described reason for receiving.

The footer currently always reads "You're receiving this notification because you are a member of the GitLab.org / GitLab Community Edition project team.", while this is not the case for the majority of people contributing to GitLab CE who are simply participating in the specific issue or merge request the notification is sent out for.

causing us confusion as well

I spent about 5m trying to figure out why I was getting an email about being a member of a group I didn't belong to, when the issue was that a teammate of mine @group'd a group I was apart of that caused me to be attached to the issue but not the group.

It would be nice if the email stated I am receiving this email because someone @group'd me instead of receiving this email because I'm apart of a group I don't belong to.

Thanks!

I looked at the code and it looks like this may be a problem for other types of emails sent from the notification service as well. The recipients come from many streams (subscribers, project watchers, mentions, etc) and the fix would involve keeping track of where a recipient came from / passing it to each mailer template.

causing us confusion as well

this would lead people to classify messages as spam

@JobV Please give this a milestone.

Milestone changed to 8.0

Not sure if this is easily done. @blaskovicz describes the point well, but I worry about the amount of change this requires.

For now I assumed this is a relatively easy-fix. If not, we should consider moving it to a later release.

"You're receiving this notification because you have an account on gitlab.example.com"

"You're receiving this notification because you contributed/subscribed to this project/thread"

Let's combine it:
"You're receiving this notification because you have an account on gitlab.example.com and contributed/subscribed to this project/thread"

Let's use GitLab vernacular and go with "participated" rather than "contributed" :) "thread" could be replaced by "discussion". Note that this still doesn't cover the case where the recipient is the assignee.

(off-topic: Is there a reason why I receive all new replies twice?)

@mrtux there isn't, it's annoying, we're aware of it, we're looking into it :)

This is a quick fix. Should be possible to do in 8.2.

Milestone changed to 8.2

mentioned in merge request !1409 (merged)

@JobV The sentence was removed entirely in !1409 (merged). I think this is good enough, we don't need to mention the actual reason, in most cases the user will know that themselves anyway, or be able to figure it out quickly. Agree that we can close this issue?

We have problems with our email being marked as SPAM. I expect every automated email to inform me why I'm receiving it. Some people might not have used GitLab for 2 years or their account might be automatically created.

I think we should have a message, but it should be generic enough so that it works in every case.

"You receive this email because of you account on HOSTNAME. To receive less emails please adjust your notification settings."

Milestone changed to 8.1

@JobV Moving this to 8.1 since we should not ship without a message.

+1 cc @dzaporozhets @DouweM

Reassigned to @DouweM

@sytses Restored footer text in !1640 (merged).

@sytses !1640 (merged) to restore the footer text was merged.

Assignee removed

mentioned in issue #3437 (closed)

Milestone removed

Added emails notifications labels

Added ~874211 label

moved to gitlab#3730

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue

mentioned in merge request !14785