Error when LDAP doesn't supply an email address

Zendesk: https://gitlab.zendesk.com/agent/tickets/16953

In this case, the customer did not have mail or any of the default mail attributes. GitLab should then assign a temporary OAuth email or ask the user to set one themselves. Instead, in this case, the log spit out Error saving user: ["Notification email is not an email you own"].

@zj Will you take a look, please?

cc/ @DouweM

@dblessing Ill sure take a look, however Im not sure this is a bug. The validation just failed, the email was not found thus this yielded an error. The error spitted out could've been more descriptive, I agree, but other than that I'm not sure this is the right direction to go in.

@zj We recently implemented a feature where users could input an email if LDAP didn't provide it. And at the very least, prior to this, a temporary email was generated by GitLab.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/3054 for recent changes.

@zj The error is definitely wrong, LDAP not providing an email is valid.

This is related to #13969 (moved). As @dblessing said, even the feature where users could input an email on their own if none is provided by the LDAP server doesn't work anymore (at least in our setup).

@zj Can you take a look at this so we can get a patch released? I think 8.6.3 may be one of the last 8.6 patches.

cc/ @rymai fyi

Milestone changed to 8.6

Added ~149423 label

I'd no idea this was scheduled. So I did a lot of other things this week. @rymai When is the next patch release?

@zj I would like to release 8.6.3 tomorrow. Be quick! ;)

Started branch error-when-ldap-doesn-t-supply-an-email-address-14559

mentioned in merge request !3477 (merged)

Status changed to closed by merge request !3477 (merged)

mentioned in commit ec3c66b9

mentioned in commit f9ab215b