"Unsubscribe" link in notification emails is triggered by anti-virus software that follows every link
Notification emails have an "unsubscribe" link that will unsubscribe the user from that thread. It doesn't require authentication or interaction (like a button click) to make it easy for people to unsubscribe from things quickly and on the go. "Authorization" is accomplished through a token in the unsubscribe URL.
Unfortunately, some email clients or anti-spam or anti-virus softwares follow links in emails to check if they contain viruses or look spammy, and are thus also triggering the unsubscribe.
We should:
- Still require no interaction when the user is already signed in
- Require interaction (like a button click) when the user isn't signed in
- Allow the interaction to be skipped even when not signed in using a
?force=true
query option - Add the
List-Unsubscribe
header with that interactionless URL, to allow users to unsubscribe directly from their mail client. See https://gitlab.com/gitlab-org/gitlab-ce/issues/17198#note_12989872.
Original Description
ZD: https://gitlab.zendesk.com/agent/tickets/21060
Auto subscribe to issues through mentions stops working after email issues.
Reproduce
On old issue pre email fix (i.e. blocked email)
-
The web page said I was not subscribed
-
I made a comment – it still said I was not subscribed
-
I was mentioned in a comment – it still said I was not subscribed – I did not receive an email
-
I manually clicked “subscribe”
-
My colleague added a comment that did NOT mention me – I DID receive an email (this is correct)
So it looks like if I manually subscribe to these broken Issues then I get notifications. But the auto-subscribe for these Issues is not working.
New issues (post email fix) seem to be working properly – auto-subscribe to Issues is functioning.
Old projects are broken:
-
I DO get email notifications for new Issues
-
I DO get email notifications for Issues if I manually subscribe
-
I do NOT get automatically subscribed to Issues even if someone mentions me or if I make a comment myself. This means that I don’t get emails about comments in which I’m mentioned, or about replies to my comments.
/cc @brodock