Relative Url - Wrong/Double references in some cases

Hi,

I'm using gitlab (7.10.4 337225a4) inside docker (sameersbn/docker-gitlab) and I've some issues in gitlab when setting a relative url (config.relative_url_root). I've set the relative url to "/gitlab" and in the network view of projects, the user avatars are referenced incorrectly now. See my issue on github for details: https://github.com/sameersbn/docker-gitlab/issues/326.

Also I have the same issue (reference to /gitlab/gitlab/... instead of /gitlab/...) when trying to login after (at least) one failed try (e.g. with wrong password): then I'm redirected to gitlab/gitlab/users/sign_in instead of gitlab/users/sign_in and an error 404 page appears ("The page you were looking for doesn't exist."). When the first login attempt is correct (right username and right password), I'm redirected correctly.

Thanks for help :)

To check this issue, I installed gitlab from source on a virtual machine (no docker) and made the following changes as described in config/application.rb

1. In your application.rb file: config.relative_url_root = "/gitlab"
2. In your gitlab.yml file: relative_url_root: /gitlab
3. In your unicorn.rb: ENV['RAILS_RELATIVE_URL_ROOT'] = "/gitlab"
4. In ../gitlab-shell/config.yml: gitlab_url: "http://127.0.0.1/gitlab"
5. In lib/support/nginx/gitlab : do not use asset gzipping, remove block starting with "location ~ ^/(assets)/"
6. sudo -u git -H bundle exec rake assets:precompile RAILS_ENV=production

After these changes, GitLab is accessible at the /gitlab relative url, but the paths to user avatars, emojis, etc. are invalid. For example, an emoji whose path should be http://git.example.com/gitlab/assets/emoji/1F603-30707f6edcbe8ea2b8923964fe735ea3.png will instead be http://git.example.com/gitlab/gitlab/assets/emoji/1F603-30707f6edcbe8ea2b8923964fe735ea3.png (notice the gitlab/gitlab/ part of the url)

Removed ~19112 label

I am also seeing this issue running gitlab 7.12.2 30bffd58.

Any help is much appreciated. Thanks,

I've added a "dirty fix" on our nginx webserver to work around that issue:

   # gitlab bug fix:
   # wrong references (e.g. avatars in network view) due to relative url
   location /gitlab/gitlab/ {
    rewrite ^(/gitlab/gitlab)(.*)$   https://mydomain.com/gitlab/$2 permanent;
   }
   location /gitlabhttps:/mydomain.com/gitlab/ {
    rewrite ^(/gitlabhttps:/mydomain.com/gitlab)(.*)$   https://mydomain.com/gitlab/$2 permanent;
   }

This is of course no solution, just a quick workaround. As you can see in my second rewrite-instruction, it also happens sometimes (e.g. when using custom avatars) that the relative '/gitlab' is put in from of the domain for some strange reason.

Same issue here with Gitlab CE 7.14.0

@stanhu Maybe something you can look into?

I confirm the issue for Gitlab CE 7.14.0

Very annoying. If someone could take a look into this :)

Blocking here too !

👍

Looks like a critical mass of people. Yet another issue relating to this: https://github.com/gitlabhq/gitlabhq/issues/9605

Will look into this.

Reassigned to @stanhu

The avatar issue might be a caching issue. Once I did:

sudo gitlab-rake cache:clear

The avatars started appearing with the right URL. Can someone try this out?

The emoji problem has to do with asset_root being set to the full external URL (e.g. http://mydomain.com/gitlab), and the path helpers return the full path as well (e.g. /gitlab/assets/emoji/XXX). I think we need to set asset_root to the host's base URL. I'm guessing there are other instances like this.

It looks like anywhere Gitlab.config.gitlab.url is used along with a path helper, Gitlab.config.gitlab.base_url should be used instead.

Seems to be the same on login redirection URL.

@stanhu I can confirm that the avatar issue is resolved after cache:clear

Thanks , @sameer.

Regarding the login redirection URL issue, I believe it is a bug in Devise. I have filed the issue here: https://github.com/plataformatec/devise/issues/3738

We can workaround this by either creating our own subclass of Devise's FailureApp or fix the problem in Devise itself.

Submitted a fix to Devise to solve the login redirection URL issue with relative paths: https://github.com/plataformatec/devise/pull/3739

mentioned in merge request !1254 (merged)

Ok, let's summarize the issues when relative_url_root is defined:

Issue	Fix	Notes
Avatar URLs	Run sudo gitlab-rake cache:clear	Events cache has old avatar URLs. This can be resolved by clearing the cache or pushing a new event
Emoji URLs	See !1254 (merged)	😄
Login redirection	See https://github.com/plataformatec/devise/pull/3739	Bug is in Devise, not GitLab
Wrong URLs generated in Web hooks	See !1250 (merged)	URLs in object_attributes had extraneous path

Status changed to closed by commit 8820785c

mentioned in commit 8820785c

mentioned in commit 0d41b2dd

@sameer FYI, I believe the login redirection bug should be fixed in Devise 3.5.3. This should be available in master and in 8.3, so please let me know if this works for you.

@stanhu tested with master and the login redirection issue does not occur.

@sameer Thanks for confirming!

mentioned in merge request !2355 (closed)