Migration failure GitLab 8.8

@guyguy333 Thanks for the report. @yorickpeterse can you please take a look at it again?

Thanks @grzesiek . Replacing default: true with default: 1 in the migrate file (20160504112519_add_run_untagged_to_ci_runner.rb) removed the error.

@guyguy333 What version of MySQL are you using?

@yorickpeterse I'm using MariaDB : mysql Ver 15.1 Distrib 5.5.41-MariaDB, for Linux (x86_64) using readline 5.1

Added database label

See lib/gitlab/database.rb: we can use true_value.

@guyguy333 We do not support MariaDB that I am aware of. Rails in turn (http://weblog.rubyonrails.org/2016/4/16/this-week-in-rails-mariadb-action-cable-and-more/) seems to not support MariaDB fully/officially until Rails 5.

Please use either PostgreSQL or MySQL, we can not help you with MariaDB.

Status changed to closed

@yorickpeterse are we sure this error will not occur in MySQL?

I ran this with MySQL 5.5. The migration fails there too:

$ RAILS_ENV=development bundle exec rake db:migrate:redo VERSION=20160504112519
Instance method "run" is already defined in Object, use generic helper instead or set StateMachines::Machine.ignore_method_conflicts = true.
== 20160504112519 AddRunUntaggedToCiRunner: migrating =========================
-- transaction_open?()
   -> 0.0001s
-- transaction()
-- add_column(:ci_runners, :run_untagged, :boolean, {:default=>nil})
   -> 0.0098s
-- change_column_default(:ci_runners, :run_untagged, true)
   -> 0.0059s
   -> 0.0179s
-- transaction()
-- quote_table_name(:ci_runners)
   -> 0.0000s
-- quote_column_name(:run_untagged)
   -> 0.0000s
-- quote(true)
   -> 0.0000s
-- exec_query("SELECT COUNT(*) AS count FROM `ci_runners`")
   -> 0.0005s
-- exec_query("\n            SELECT id\n            FROM `ci_runners`\n            ORDER BY id ASC\n            LIMIT 1 OFFSET 0\n          ")
   -> 0.0004s
-- exec_query("\n            SELECT id\n            FROM `ci_runners`\n            ORDER BY id ASC\n            LIMIT 1 OFFSET 1\n          ")
   -> 0.0004s
-- execute("\n            UPDATE `ci_runners`\n            SET `run_untagged` = 'true'\n            WHERE id >= 1\n          ")
-- remove_column(:ci_runners, :run_untagged)
   -> 0.0158s
rake aborted!
StandardError: An error has occurred:

Mysql2::Error: Incorrect integer value: 'true' for column 'run_untagged' at row 1: 
            UPDATE `ci_runners`
            SET `run_untagged` = 'true'
            WHERE id >= 1
          /home/stanhu/dev/gdk-mysql/gitlab/config/initializers/connection_fix.rb:20:in `execute'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:78:in `update_column_in_batches'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:120:in `block in add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:119:in `add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb:6:in `up'
ActiveRecord::StatementInvalid: Mysql2::Error: Incorrect integer value: 'true' for column 'run_untagged' at row 1: 
            UPDATE `ci_runners`
            SET `run_untagged` = 'true'
            WHERE id >= 1
          
/home/stanhu/dev/gdk-mysql/gitlab/config/initializers/connection_fix.rb:20:in `execute'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:78:in `update_column_in_batches'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:120:in `block in add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:119:in `add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb:6:in `up'
Mysql2::Error: Incorrect integer value: 'true' for column 'run_untagged' at row 1
/home/stanhu/dev/gdk-mysql/gitlab/config/initializers/connection_fix.rb:20:in `execute'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:78:in `update_column_in_batches'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:120:in `block in add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/lib/gitlab/database/migration_helpers.rb:119:in `add_column_with_default'
/home/stanhu/dev/gdk-mysql/gitlab/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb:6:in `up'
Tasks: TOP => db:migrate:up
(See full trace by running task with --trace)

Status changed to reopened

@stanhu I have tried on MySQL 5.5 and 5.7 using latest docker images, and it was OK. Which version of MySQL did you try exactly?

@grzesiek Are you sure you had a CI runner configured? The migration does nothing if there are no runners.

ii  mysql-server-5.5                    5.5.49-0ubuntu0.14.04.1             amd64        MySQL database server binaries and system database setup

@stanhu Good catch, this was probably the reason why it passed in my environment. Checking again.

There seems to be a difference between what quote does when called on ActiveRecord::Base.connection and when called in a migration:

2.1.8p440 > ActiveRecord::Base.connection.quote(true)
=> "1"
2.1.8p440 > m = ActiveRecord::Migration.new
=> #<ActiveRecord::Migration:0x00559af88bc598 @connection=nil, @name="ActiveRecord::Migration", @version=nil>
2.1.8p440 > m.quote(true)
-- quote(true)
   -> 0.0001s
=> "'true'"

Confirmed that this doesn't work on MySQL when there are records in table that needs update due to default value.

mentioned in merge request !4239 (merged)

Status changed to closed by merge request !4239 (merged)

mentioned in commit b4c47368

mentioned in issue #17725 (closed)

mentioned in commit 1f9004a8

mentioned in merge request !14785

Migration failure GitLab 8.8

Summary

Steps to reproduce

Expected behavior

Relevant logs and/or screenshots

Output of checks

Results of GitLab Application Check

Results of GitLab Environment Info

Possible fixes

Designs

Child items ...

Activity

Admin message

Admin message

Migration failure GitLab 8.8

Summary

Steps to reproduce

Expected behavior

Relevant logs and/or screenshots

Output of checks

Results of GitLab Application Check

Results of GitLab Environment Info

Possible fixes

Activity