Filebrowser returns 500 for folder with gitmodule

I have a repository, which contains a relative gitmodule.

When accessing the path, which contains the gitmodule I get a 500 with following log:

Started GET "/xxx/yyy/tree/master/SW" for 1.2.3.4 at 2015-06-22 14:37:13 +0200
Processing by Projects::TreeController#show as HTML
Parameters: {"namespace_id"=>"master-project", "project_id"=>"yyy", "id"=>"master/SW"}
Completed 500 Internal Server Error in 155ms
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"projects", :format=>nil, :id=>"zzz", :namespace_id=>"XXX", :project_id=>"yyy"} missing required keys: [:namespace_id]):
1: %tr{ class: "tree-item" }
2: %td.tree-item-file-name
3: %i.fa.fa-archive.fa-fw
4: = submodule_link(submodule_item, @ref)
5: %td
6: %td.hidden-xs
app/helpers/submodule_helper.rb:70:in `relative_self_links'
app/helpers/submodule_helper.rb:19:in `submodule_links'
app/helpers/diff_helper.rb:153:in `submodule_link'
app/views/projects/tree/_submodule_item.html.haml:4:in `_app_views_projects_tree__submodule_item_html_haml___4155254840449227775_44639920'
app/helpers/tree_helper.rb:21:in `render_tree'
app/views/projects/tree/_tree.html.haml:42:in `_app_views_projects_tree__tree_html_haml__3794571156875204699_40109140'
app/views/projects/tree/show.html.haml:14:in `_app_views_projects_tree_show_html_haml___3744984418233273813_38641980'
app/controllers/projects/tree_controller.rb:21:in `show'

Expected behavior

I can see a link to the gitmodule repository.

Affected versions:

• GitLab 7.11.2 dac18e77

Working versions:

• GitLab 7.7.2 bd982900

/cc @stanhu I assume there is some issue with gitlab_git. I think you investigated a lot in gitlab_git. Do you have any clue about this error?

@razer6 Actually, this doesn't look like an issue with gitlab_git. It looks like GitLab is trying to create a link to a GitLab project but complains that namespace_id isn't present when it appears to be present based on your logs. It looks like the logs may have been scrubbed here; is namespace_id present and correct?

@stanhu Thanks for pointing out. The namespace id seems to be wrong. In the 500 request, namespace_id is set to Master Project. In a working request to a project of this namespace namespace_id is set to master-project.

One thing to mention here. The namespace was renamed once. Maybe that is related here.

What is the relative URL in .gitmodules? Does it look something like this?

../Master Project/repo.git

Nope. The path looks like the following:

url = ../repo.git

I think GitLab then uses the group name (Master Project) for the namespace instead of the group path master-project.

Ah, this line:

      namespace = @project.namespace.name

Should probably be:

      namespace = @project.namespace.path

In most cases, it looks like name == path.

I can confirm changing this line fixes the problem

Ok, I'll submit a MR for this. Thanks!

Awesome

mentioned in merge request !864 (merged)

Status changed to closed by commit 774b7ee2

mentioned in merge request !14785