Skip to content
Snippets Groups Projects
Closed (moved) Investigate code with less than 60% tests coverage
  • View options
  • Investigate code with less than 60% tests coverage

  • View options
  • Closed (moved) Issue created by Grzegorz Bizon

    Currently we have a bunch of files with less than 60% of code coverage, and big part of those files has 0% coverage (which may indicate we no longer use those files, or that we have a trouble).

    File Coverage
    app/controllers/oauth/authorizations_controller.rb 0.0 %
    app/controllers/omniauth_callbacks_controller.rb 0.0 %
    app/controllers/sherlock/application_controller.rb 0.0 %
    app/controllers/sherlock/file_samples_controller.rb 0.0 %
    app/controllers/sherlock/queries_controller.rb 0.0 %
    app/controllers/sherlock/transactions_controller.rb 0.0 %
    app/models/project_services/gitlab_ci_service.rb 0.0 %
    app/services/ci/web_hook_service.rb 0.0 %
    app/services/milestones/reopen_service.rb 0.0 %
    app/services/projects/import_export/export_service.rb 0.0 %
    app/workers/admin_email_worker.rb 0.0 %
    app/workers/gitlab_remove_project_export_worker.rb 0.0 %
    app/workers/project_export_worker.rb 0.0 %
    app/workers/project_web_hook_worker.rb 0.0 %
    app/workers/repository_archive_cache_worker.rb 0.0 %
    lib/ci/static_model.rb 0.0 %
    lib/ci/version_info.rb 0.0 %
    lib/gitlab/fogbugz_import/importer.rb 0.0 %
    lib/gitlab/fogbugz_import/project_creator.rb 0.0 %
    lib/gitlab/fogbugz_import/repository.rb 0.0 %
    lib/gitlab/gitlab_import/importer.rb 0.0 %
    lib/gitlab/import_export/error.rb 0.0 %
    lib/gitlab/import_export/saver.rb 0.0 %
    lib/gitlab/import_export/version_saver.rb 0.0 %
    lib/gitlab/issues_labels.rb 0.0 %
    lib/gitlab/markdown/pipeline.rb 0.0 %
    lib/gitlab/o_auth/session.rb 0.0 %
    lib/gitlab/seeder.rb 0.0 %
    lib/gitlab/sidekiq_middleware/arguments_logger.rb 0.0 %
    lib/gitlab/sidekiq_middleware/memory_killer.rb 0.0 %
    lib/omni_auth/request_forgery_protection.rb 0.0 %
    lib/version_check.rb 0.0 %
    lib/tasks/gitlab/shell.rake 14.93 %
    lib/gitlab/backend/grack_auth.rb 20.0 %
    lib/gitlab/github_import/importer.rb 31.31 %
    app/helpers/tags_helper.rb 37.5 %
    lib/backup/repository.rb 37.5 %
    lib/tasks/gitlab/db.rake 41.38 %
    app/controllers/import/fogbugz_controller.rb 41.82 %
    lib/tasks/gitlab/task_helpers.rake 43.75 %
    app/models/project_services/campfire_service.rb 45.71 %
    lib/gitlab/bitbucket_import/key_adder.rb 46.15 %
    app/controllers/import/google_code_controller.rb 46.88 %
    app/controllers/projects/protected_branches_controller.rb 48.0 %
    app/controllers/admin/abuse_reports_controller.rb 50.0 %
    app/controllers/confirmations_controller.rb 50.0 %
    lib/disable_email_interceptor.rb 50.0 %
    lib/gitlab/recaptcha.rb 50.0 %
    lib/gitlab/upgrader.rb 50.0 %
    lib/backup/database.rb 53.57 %
    app/helpers/runners_helper.rb 53.85 %
    lib/gitlab/ldap/adapter.rb 54.55 %
    lib/gitlab/gitlab_import/client.rb 55.0 %
    lib/gitlab/github_import/client.rb 58.54 %
    lib/gitlab/fogbugz_import/client.rb 58.82 %

    60% is still a very low value, and we still can improve coverage in some classes, but let's keep track on specific cases in separate issues.

    What do you think @dzaporozhets @DouweM @rspeicher ?

    Linked items 0

  • Link items together to show that they're related or that one is blocking others.

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first