Fix `master` build
Failure Message
1) RegistrationsController#create when sending email confirmation logs user in directly
Failure/Error: expect(ActionMailer::Base.deliveries.last).to be_nil
expected: nil
got: #<Mail::Message:47417340220460, Multipart: true, Headers: <Date: Mon, 04 Jul 2016 18:09:03 +0000>, <F...85/gitlabhq>, <X-GitLab-MergeRequest-ID: 5>, <X-GitLab-Reply-Key: ddecc9867e4ffac7ddb6ff682b7f797d>>
# ./spec/controllers/registrations_controller_spec.rb:18:in `block (4 levels) in <top (required)>'
# ./spec/controllers/registrations_controller_spec.rb:7:in `block (4 levels) in <top (required)>'
# ./spec/controllers/registrations_controller_spec.rb:6:in `block (3 levels) in <top (required)>'
Progress: |====================================================================|
Knapsack report was generated. Preview:
{
"spec/features/issues/filter_issues_spec.rb": 158.65969610214233,
"spec/requests/api/issues_spec.rb": 157.15000414848328,
"spec/features/security/project/snippet/internal_access_spec.rb": 80.8062310218811,
"spec/lib/banzai/filter/issue_reference_filter_spec.rb": 33.331196308135986,
"spec/features/issues/issue_sidebar_spec.rb": 40.04430913925171,
"spec/features/projects_spec.rb": 45.337294816970825,
"spec/requests/api/award_emoji_spec.rb": 33.876116037368774,
"spec/helpers/gitlab_markdown_helper_spec.rb": 15.378220558166504,
"spec/services/projects/update_service_spec.rb": 21.100306510925293,
"spec/features/issues/new_branch_button_spec.rb": 16.349832773208618,
"spec/workers/emails_on_push_worker_spec.rb": 11.751931190490723,
"spec/finders/notes_finder_spec.rb": 10.012051105499268,
"spec/lib/banzai/pipeline/wiki_pipeline_spec.rb": 13.287210464477539,
"spec/lib/banzai/filter/external_issue_reference_filter_spec.rb": 10.051526308059692,
"spec/controllers/snippets_controller_spec.rb": 8.201475620269775,
"spec/controllers/sessions_controller_spec.rb": 7.655276298522949,
"spec/models/ability_spec.rb": 8.200751066207886,
"spec/services/merge_requests/reopen_service_spec.rb": 11.620822191238403,
"spec/lib/banzai/reference_parser/issue_parser_spec.rb": 7.583648443222046,
"spec/features/dashboard/label_filter_spec.rb": 8.940105438232422,
"spec/controllers/projects/commit_controller_spec.rb": 4.786456823348999,
"spec/lib/gitlab/bitbucket_import/project_creator_spec.rb": 3.606149435043335,
"spec/controllers/import/google_code_controller_spec.rb": 3.1446075439453125,
"spec/features/groups/members/member_leaves_group_spec.rb": 3.4098849296569824,
"spec/services/ci/create_builds_service_spec.rb": 3.8473124504089355,
"spec/controllers/import/gitorious_controller_spec.rb": 3.413797616958618,
"spec/lib/gitlab/diff/file_spec.rb": 2.7714149951934814,
"spec/controllers/registrations_controller_spec.rb": 1.877126932144165,
"spec/services/notes/post_process_service_spec.rb": 1.7777423858642578,
"spec/lib/gitlab/highlight_spec.rb": 2.590942144393921,
"spec/features/projects/members/anonymous_user_sees_members_spec.rb": 2.2065622806549072,
"spec/lib/banzai/reference_parser/label_parser_spec.rb": 1.5037474632263184,
"spec/lib/gitlab/blame_spec.rb": 0.4794595241546631,
"spec/lib/gitlab/bitbucket_import/client_spec.rb": 0.9268567562103271,
"spec/lib/gitlab/snippet_search_results_spec.rb": 0.7210657596588135,
"spec/lib/gitlab/metrics/sampler_spec.rb": 0.2271568775177002,
"spec/lib/gitlab/regex_spec.rb": 0.05904388427734375,
"spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb": 0.03972911834716797,
"spec/lib/container_registry/repository_spec.rb": 0.06821513175964355,
"spec/lib/gitlab/key_fingerprint_spec.rb": 0.028618812561035156,
"spec/helpers/notifications_helper_spec.rb": 0.03391909599304199,
"spec/lib/gitlab_spec.rb": 0.010384559631347656,
"spec/models/project_services/slack_service/note_message_spec.rb": 0.013191461563110352,
"spec/lib/banzai/filter/task_list_filter_spec.rb": 0.011256933212280273
}
Knapsack global time execution for tests: 12m 16s
Finished in 13 minutes 9 seconds (files took 19.65 seconds to load)
450 examples, 1 failure
Failed examples:
rspec ./spec/controllers/registrations_controller_spec.rb:16 # RegistrationsController#create when sending email confirmation logs user in directly
Coverage report generated for RSpec to /builds/gitlab-org/gitlab-ce/coverage. 112138 / 229088 LOC (48.95%) covered.
Links
Failing build: https://gitlab.com/gitlab-org/gitlab-ce/builds/2170031