Add `Project#add_[role]` methods

We do something like this hundreds of times throughout our specs: project.team << [user, :developer]. It'd be a nicer interface if we could just say project.add_developer(user).

We have a similar interface for Group.

@rspeicher since project.team << can be used to add other access levels wdyt about abstracting the method a bit more, something like project#add_member(user, access) :)

@dixpac The idea was that there would be one for each role:

project.add_developer(user)
project.add_reporter(user)
# etc.

See the Group example in the OP. Or am I misunderstanding?

@rspeicher Hi Robert, I'd like to work on this. I'm a newbie here and I would like to get involved in the project.

mentioned in merge request !5990 (closed)

@rspeicher yea I didn't understand you initially, I thought you only wanted add_developer, anyway I've started to work on this will ping you in next days when I think that is ready

mentioned in merge request !5992 (closed)

@rspeicher There's MR and it's ready for review https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5992

Removed ~131895 label

@itsnikolay @dixpac two MRs in the space of half an hour! https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5990 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5992 Thanks, we'll only be able to take one though.

@rspeicher my PR has:

• less hardcode
• more OOP (not overweights Project model)
• current_user support
• unit tests for added methods

mentioned in merge request !6012 (closed)

mentioned in merge request !6120 (closed)

@rspeicher I have created separate MRs with discussed changes:

• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5992
• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6120 (contains the same hex commit from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5992)

Could you review them, pls? cc @smcgivern , @dixpac

Milestone changed to %8.13

Added ~480950 label

Milestone changed to %Backlog

Reassigned to @rspeicher

Mentioned in commit eef36091

Mentioned in merge request !7565 (merged)

Status changed to closed by merge request !7565 (merged)

mentioned in merge request !14785