Rouge warning noise

I see the following whenever the app loads (e.g. during rake commands) on 82f0d3e6

/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: already initialized constant Rouge::Lexers::Shell::KEYWORDS
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: previous definition of KEYWORDS was here
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: already initialized constant Rouge::Lexers::Shell::BUILTINS
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: previous definition of BUILTINS was here

It would be nice to address/quash these warnings.

@stanhu could this be because of e6feb987 ?

Most likely, but I'm not quite sure why yet.

It looks like rouge attempts to load lexers/shell.rb twice:

https://github.com/jneen/rouge/blob/master/lib/rouge/lexers/powershell.rb#L5 https://github.com/jneen/rouge/blob/master/lib/rouge.rb#L43

Filed issue under Rouge: https://github.com/jneen/rouge/issues/296

Still waiting for the PR to be accepted: https://github.com/jneen/rouge/pull/298

@stanhu maybe contact https://github.com/jneen directly?

Milestone changed to 8.0

Yes, sent an e-mail.

Thanks for being awesome and chasing this issue upstream @stanhu

+1 on 7.14.1

mentioned in issue #2482 (closed)

Looks like a fix for this issue was just checked in:

https://github.com/jneen/rouge/commit/0b91f25bedecdffba05300821ef6f1e49334abf7

Now we await a new rouge release. :)

mentioned in merge request !1277 (merged)

mentioned in merge request !1277 (merged)

Status changed to closed by commit 3223a2a5

mentioned in commit 3223a2a5

mentioned in commit 7904a751

mentioned in merge request !14785