Can't uncheck "Reset approvals on push" in project settings
I found that i cant uncheck "Reset approvals on push" in project settings, just on gitlab.com
Reproduce:
- Uncheck "Reset approvals on push" in project settings.
- Then save.
You can see that it doesnt work, "Reset approvals on push" is always checked.
I think :reset_approvals_on_push
was forgot to be added to project_params
in project_controller.rb
def project_params
params.require(:project).permit(
:name, :path, :description, :issues_tracker, :tag_list,
:issues_enabled, :merge_requests_enabled, :snippets_enabled, :issues_tracker_id, :default_branch,
:wiki_enabled, :merge_requests_template, :visibility_level, :merge_requests_rebase_enabled,
:import_url, :last_activity_at, :namespace_id, :avatar, :merge_requests_rebase_default,
:approvals_before_merge, :approver_ids, :reset_approvals_on_push
)
end