New state for skipped builds that are waiting for manual action trigger

Description

We treat any job that is skilled as skipped, but should treat manual actions differently.

Proposal

• Create a new state for non-triggered manual action builds

Single Source of Truth

Icon can be found here

Links / references

Mentioned in issue #22643 (moved)

Mentioned in issue #22628 (closed)

Reassigned to @dimitrieh

Mentioned in issue #22445 (closed)

Milestone changed to %8.13

Sort of part of: https://gitlab.com/gitlab-org/gitlab-ce/issues/22628#note_16372438

Wording can be argued over, but I think manual is sufficient.

@markpundsack @tauriedavis

gave this %8.13 milestone

Mentioned in issue #22191 (closed)

The cog wheel might be a bit heavy for this purpose, but I can't think of anything better. :)

cc @ayufan

For completeness, I previously suggested using 3 horizontal dots. I don't think it works well at small sizes, but to me conveyed the "waiting" part of "waiting for a manual action".

@markpundsack I tried out various icons ;) And discussed with @awhildy and @tauriedavis that gear icon is the best.. also for the three dots.. they are used in gitlab for extending something.. something that has been truncated for example.. so dont want to cross pollenate :)

cc: @lbennett @annabeldunstone @filipa

Added frontend and removed ~19492 labels

Assignee removed

I don't think that this is doable for 8.13.

Reassigned to @lbennett

We treat any job that is skilled as skipped

Judging from this, my experience with the statusof the Play pipeline actions (which is skipped), and @ayufan's comment above, this needs backend?

I will unassign for now, I see its on the CI plan so we shouldn't lose track of it.

Assignee removed

Mentioned in issue #22914 (closed)

cc: @ayufan

Added ~480950 label

Mentioned in issue #23492 (closed)

Milestone changed to %Backlog

Mentioned in issue #23441 (closed)

@smcgivern any reason why you changed this to %Backlog ? its on the CI plan for %8.14 https://gitlab.com/gitlab-org/gitlab-ce/issues/23492

@dimitrieh good catch, thanks! That was probably a misclick, I was moving a lot of issues yesterday I've moved it back now and unassigned Platform .

Removed ~480950 label

Milestone changed to %8.14

It would also be useful to have the status differentiate between manual tasks that are ready to run and manual tasks that should not be ran due to failed dependencies. See #23441 (closed) and #20594 (moved).

@smcgivern no problem! darn want to use award emoji

@deckar01 would manual tasks that should not be ran due to failed dependencies not get the status "skipped" ?

No, the problem is that manual tasks are given the "skipped" status when their dependencies pass. The status when the dependencies pass would need to be something like "pending manual action", so that the "skipped" status can be normalized to never allow retrying (like it already does for automatic tasks).

#20594 (moved) also suggests that stages after a manual action should wait for the manual action to pass before continuing, which requires the differentiation between manual tasks with passed and failed dependencies.

@deckar01

I believe that we have two different flows:

1. one is to make manual actions blocking,
2. is to make manual actions non-blocking.

Currently we support 2. and use the skipped for that.

I right now think that what makes sense is to make 1. and enable that by adding a separate status that would have distinct visuals. We could effectively show that everywhere that pipeline needs your action, because some stages are blocked.

I don't necessarily need to block the pipeline for my use case, I am just concerned that it lets me manually deploy broken builds (which I did accidentally).

On update to 8.13.1 from 8.12.3 the main pipeline page stopped displaying status "skipped" for pipelines with a manual build, it shows "passed" - as tests indeed did pass. Is this intentional, as a step toward addressing this issue? Indeed a status indication of waiting for manual action would be ideal.

But for now, I no longer can tell which part of a pipeline hasn't had the manual deploy run (we just use a manual stage for deploy for a project). This is a problem with multiple people responsible for deploys. You have to go look at the particular pipeline. Status is meaningless now in the main page.

Scott

@sknolin What you're describing was broken by !6604 (merged) which attempted to fix #22598 (closed), actually I think that's a regression which we should fix :x /cc @ayufan

Mentioned in issue #23935 (closed)

Yes. I agree with @godfat here that we should fix that.

Added ~901060 and removed frontend labels

Mentioned in issue #19703 (closed)

Milestone changed to %8.15

mentioned in issue #25314 (closed)

mentioned in merge request !7989 (merged)

cc: @grzesiek i think this is part of what you are working on right now correct?

assigned to @grzesiek

@dimitrieh Correct!

closed via merge request !7989 (merged)

mentioned in issue gitlab#6387