API - Merge request sorting

Merge request sorting on API does not work.

These URL return the same result:

/api/v3/projects/3/merge_requests
/api/v3/projects/3/merge_requests?order_by=updated_at&sort=desc
/api/v3/projects/3/merge_requests?order_by=updated_at&sort=asc
/api/v3/projects/3/merge_requests?order_by=created_at&sort=desc
/api/v3/projects/3/merge_requests?order_by=created_at&sort=asc

Version: 7.13.5-ce.0

Thanks

It's realy a bug ! They return the same result . Yestday , I try to reinstall gitlab twice ,but it also not work . When is can be fixed?

i found the code,bug it not using "params[:sort]"

        get ":id/merge_requests" do
        authorize! :read_merge_request, user_project
        merge_requests = user_project.merge_requests

        unless params[:iid].nil?
          merge_requests = filter_by_iid(merge_requests, params[:iid])
        end

        merge_requests =
          case params["state"]
          when "opened" then merge_requests.opened
          when "closed" then merge_requests.closed
          when "merged" then merge_requests.merged
          else merge_requests
          end

        merge_requests.reorder(issuable_order_by => issuable_sort)
        present paginate(merge_requests), with: Entities::MergeRequest
      end

No longer support sorting? or it's a bug?

params[:sort] is in issuable_sort method

It's a bug. I think the line:

merge_requests.reorder(issuable_order_by => issuable_sort)

Needs to be:

merge_requests = merge_requests.reorder(issuable_order_by => issuable_sort)

I'll send a MR.

mentioned in merge request !1305 (merged)

Status changed to closed by commit 1c289ac0

mentioned in commit 1c289ac0

mentioned in commit 7d59ba00

Mentioned in commit pfjason/gitlab-ce@7d59ba00

mentioned in merge request !14785