Skip to content

Replace all Spinach tests with Rspec feature tests

We decided earlier this year (in #14121 (closed)) to stop writing new Spinach feature tests. I wanted to open an issue about replacing all the Spinach tests with Rspec feature tests where relevant.

Here's a list of all the Spinach test files and how long they took to execute for a randomly chosen commit, it's probably a good idea to start with the fastest/smallest specs first if you want an easy MR:

Updated (May 12, 2017)

Here are all current spinach specs sorted by lines of code.

Spec Lines of code Replacement status
features/project/source/browse_files.feature 333 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12251
features/project/merge_requests.feature 324 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14621
features/project/issues/issues.feature 180 Not yet replaced
features/project/source/markdown_render.feature 147 Not yet replaced
features/explore/projects.feature 144 Not yet replaced
features/project/active_tab.feature 139 Not yet replaced
features/project/wiki.feature 101 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13856
features/search.feature 96 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14248
features/project/commits/diff_comments.feature 96 Not yet replaced
features/project/commits/commits.feature 96 Not yet replaced
features/explore/groups.feature 93 Not yet replaced
features/project/service.feature 87 Repalced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14432
features/project/pages.feature 87 Not yet replaced
features/user.feature 86 Not yet replaced
features/project/project.feature 86 Not yet replaced
features/profile/profile.feature 85 Not yet replaced
features/groups.feature 73 Not yet replaced
features/group/members.feature 71 Not yet replaced
features/dashboard/dashboard.feature 70 Replaced by !12876 (merged)
features/project/builds/artifacts.feature 65 Not yet replaced
features/project/shortcuts.feature 63 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14431
features/dashboard/event_filters.feature 58 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12651
features/project/builds/permissions.feature 53 Not yet replaced
features/project/forked_merge_requests.feature 51 Not yet replaced
features/project/commits/comments.feature 51 Not yet replaced
features/project/fork.feature 49 Not yet replaced
features/project/issues/labels.feature 48 Not yet replaced
features/group/milestones.feature 48 Not yet replaced
features/project/network_graph.feature 46 Not yet replaced
features/project/deploy_keys.feature 46 Not yet replaced
features/project/issues/award_emoji.feature 45 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14202
features/invites.feature 45 Not yet replaced
features/project/find_file.feature 42 Not yet replaced
features/project/commits/branches.feature 42 Not yet replaced
features/snippets/snippets.feature 40 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12385
features/project/star.feature 39 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13855
features/project/issues/milestones.feature 39 Not yet replaced
features/project/redirects.feature 38 Not yet replaced
features/project/hooks.feature 37 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11027
features/project/snippets.feature 35 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14326
features/project/issues/references.feature 33 Not yet replaced
features/project/graph.feature 33 Not yet replaced
features/project/merge_requests/references.feature 31 Not yet replaced
features/project/commits/revert.feature 31 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14325
features/project/archived.feature 30 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14322
features/dashboard/new_project.feature 30 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12550
features/project/merge_requests/revert.feature 29 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14201
features/profile/active_tab.feature 29 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14239
features/dashboard/todos.feature 28 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12453
features/project/merge_requests/accept.feature 27 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14176
features/project/builds/summary.feature 27 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14177
features/project/badges/build.feature 27 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12966
features/project/team_management.feature 26 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14173
features/profile/emails.feature 26 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14172
features/dashboard/merge_requests.feature 21 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12440
features/project/milestone.feature 16 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14171
features/project/group_links.feature 16 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14169
features/project/commits/user_lookup.feature 16 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13863
features/project/source/search_code.feature 15 Replaced by !13697 (merged)
features/profile/notifications.feature 15 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12345
features/project/create.feature 14 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12343
features/dashboard/starred_projects.feature 12 Replaced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11752

These should be done one-at-a-time and we should make sure we're not duplicating existing RSpec feature tests.

Some resources to help newcomers get going:

Edited by username-removed-86853