Sidekiq throttler can't be run before database migrations
While trying to start up my EE GDK environment, I ran into:
14:36:28 rails-background-jobs.1 | undefined method `sidekiq_throttling_enabled' for #<ApplicationSetting:0x007fdc851cf160>
14:36:28 rails-background-jobs.1 | Did you mean? sidekiq_throttling_enabled?
14:36:28 rails-background-jobs.1 | /Users/stanhu/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-4.2.7.1/lib/active_model/attribute_methods.rb:433:in `method_missing'
14:36:28 rails-background-jobs.1 | /Users/stanhu/gitlab/gdk-ee/gitlab/lib/gitlab/current_settings.rb:27:in `sidekiq_throttling_enabled?'
14:36:28 rails-background-jobs.1 | /Users/stanhu/gitlab/gdk-ee/gitlab/lib/gitlab/sidekiq_throttler.rb:5:in `execute!'
14:36:28 rails-background-jobs.1 | /Users/stanhu/gitlab/gdk-ee/gitlab/config/initializers/sidekiq.rb:35:in `block in <top (required)>'
14:36:28 rails-background-jobs.1 | /Users/stanhu/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/sidekiq-4.2.1/lib/sidekiq.rb:72:in `configure_server'
14:36:28 rails-background-jobs.1 | /Users/stanhu/gitlab/gdk-ee/gitlab/config/initializers/sidekiq.rb:8:in `<top (required)>'
The problem is that I can only do this migration if the DB is up.
Perhaps we should disable throttling if either the column is not available or migrations have not all run?