Implement pagination in the events screen of cycle analytics

Currently, there is no pagination when there are a lot of rows for any of the stage events:

This makes it difficult to navigate as the scrollbar can get very tiny and there could be hundreds or thousands of rows. We could add pagination so the UX is nicer.

I propose we do the pagination logic in the backend, as that will speed things up a lot. We also need a UX design first for the frontend to work on.

/cc @regisF @alfredo1

Not sure who will do the UX part and when should we implement this (i.e should it be in a patch release for 8.14?) /cc @regisF @JobV

If this causes timeout issues for our own volume of issues, definitely a patch release.

Why not just limit the amount of issues in a patch release? We can do pagination in another release, if it's more work (!).

@regisF @JobV: Would we need to indicate somewhere that we are limiting the amount of issues?

@hazelyang: Part of me wonders why this is a scrollable area inside the page, and I just kind of want the issue list to scroll as the page scrolls, having the stages on the left be sticky/fixed on screen as you scroll. Was that idea considered? Thanks!

@awhildy yeah, we had that for the first iteration of issue board anyway (showing only X issues).

Why not just limit the amount of issues in a patch release? We can do pagination in another release, if it's more work (!).

If we go for that, showing only X events or limiting the number of events (setting a maximum) is straightforward from the backend perspective. Probably not much to do in the frontend - apart from an indication that there's a limit/max.

@jameslopez just so we are clear: the total shown at the stage level still would count the total number of issues, regardless if we limit the number of events.

@regisF yep, of course! But we'll need to clarify that somewhere, as it won't add up :)

Can we say Showing X of Y issues so you get an idea of how many issues aren't showing?

Mentioned in issue #22940 (closed)

@regisF what would be a reasonable number to limit the events?

This is already a problem for gitlab-org group - https://gitlab.com/gitlab-org/gitlab-ce/issues/22940

Reassigned to @jameslopez

Milestone changed to %8.15

@jameslopez what about 50?

Mentioned in merge request !7743 (merged)

Assignee removed

@regisF this is now implemented in the backend and the MR is ready to be merged. However, we probably want to do the Showing X of Y issues thing in the frontend first before merging... /cc @alfredo1

@jameslopez yes!

@alfredo1 we can probably take the same style as the one that is on the issue board for this Showing X of Y message.

@jameslopez do you want me to look on that? regarding the Showing X of Y message

@alfredo1 yes please, I assume this is more a frontend thing ? We are not paginating yet - just limiting the rows to 50...

@alfredo1 if you need help to design this, just ping @hazelyang 😀

actually, now that I think about it this may require more work from the backend if we want to show the real Y - without the max. In fact, since we'll have to show this somehow in the JSON and also run an extra query to get the total number without the limit.... I would rather implement pagination directly.

This was meant to be a quick fix so we can put it in patch release and leave the pagination work to 8.15... My suggestion would be to either show something like limited to a maximum of 50 events if events > 50 (which just requires small work), or implement pagination directly - but this will take longer.

Totally get not overcomplicating this. If we can't have Showing X of Y, maybe just say Showing X events. If more explanation is needed, that can be added to the tooltip.

removed ~480950 label

changed milestone to %8.16

removed milestone

added to schedule label

assigned to @samrose3

@awhildy What do you think of the Showing X events with tooltip?

Thanks @samrose3! Using a tooltip is a good solution.

The text might be a little confusing. Does Limited to showing 50 events at most make sense?

Would it be possible to put a little warning icon next to the 'Showing 5 events' text only in the state that we are at max, showing 50 events, and show the tooltip from that icon? That way, you only get the tooltip in the situations where it is relevant. Let me know if that is out of scope... 😉

@awhildy that makes perfect sense! Thank you 👍

@awhildy look good to you? This text will only show when there are 50 events. Tooltip is over the warning icon ⚠️

Looks fantastic. Thanks @samrose3! 😄

mentioned in issue #26629 (moved)

removed assignee

mentioned in merge request !10179 (merged)

mentioned in issue #30046 (moved)

moved to gitlab#7139

Hey! 👋

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue