MRs in comments are linked in the dashboard

See here:

It says Closing in favor of !1340. However, !1340 is not a link. This works for isses.

mentioned in issue #2572 (closed)

Users aren't linked a lot of the time either. Not sure what the cause is.

mentioned in merge request !1353 (merged)

The issue is that event_note in events_helper.rb is specifying a project that is being ignored by markdown, which is using a non-existent @project. Sent a MR: !1353 (merged)

Status changed to closed by commit 3b39b648

mentioned in commit 3b39b648

mentioned in commit 46173ec8

Odd, I think I'm still seeing this bug on 8.0.0rc4 deployed on GitLab.com:

I can't seem to reproduce the issue locally, though. Is there some odd caching issue, or did something not restart?

@rspeicher Do you see this too?

@stanhu Yes, weird:

My best guesses are either "I'unno, cache issues?" or that the helper that strips the first line out of some Markdown is doing something dumb.

@stanhu @rspeicher I saw not linked usernames before. But that never happened for MRs/issues

Cache issues doesn't make sense, since user profiles are public and anyone should be able to see them. (Right?)

It's gotta be something with the first_line_in_markdown and/or truncate_visible helper. Notice that when the links don't work there's the ellipsis at the end, and when they do work there's not.

Lets make a truncate filter

Status changed to reopened

@rspeicher It's a bug in truncate_if_block that only occurs under two conditions: there are multiple lines in the comment, and the first line isn't truncated. On this line, the entire paragraph block is scanned, and all formatting inside the first line is removed as a result.

Notice the difference taken from this comment:

It's probably a bug that's been around but nobody noticed until now.

mentioned in merge request !1401 (merged)

MR above would fix this. Ends up in 8.1.

Milestone changed to 8.1

Status changed to closed by commit a7b0ee3f

mentioned in commit a7b0ee3f

mentioned in commit 0175769a

mentioned in merge request !14785