Transient broken master
We seem to get the following failure (https://gitlab.com/gitlab-org/gitlab-ce/builds/13222807) pretty consistently since !10017 (merged):
Feature: Project Commits Diff Comments
Scenario: I can comment on a commit diff
! Given I sign in as a user # features/steps/shared/authentication.rb:7
~ And I own project "Shop"
~ And I visit project commit page
~ Given I leave a diff comment like "Typo, please fix"
~ Then I should see a diff comment saying "Typo, please fix"
bundler: failed to load command: spinach (/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/bin/spinach)
Capybara::Poltergeist::JavascriptError: One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
ReferenceError: Can't find variable: jQuery
ReferenceError: Can't find variable: jQuery
at undefined:1
at :1
at :1
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/poltergeist-1.9.0/lib/capybara/poltergeist/browser.rb:351:in `command'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/poltergeist-1.9.0/lib/capybara/poltergeist/browser.rb:123:in `evaluate'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/poltergeist-1.9.0/lib/capybara/poltergeist/driver.rb:136:in `evaluate_script'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/capybara-2.6.2/lib/capybara/session.rb:537:in `evaluate_script'
/builds/gitlab-org/gitlab-ee/spec/support/wait_for_ajax.rb:9:in `finished_all_ajax_requests?'
/builds/gitlab-org/gitlab-ee/spec/support/wait_for_ajax.rb:4:in `block in wait_for_ajax'
/usr/local/lib/ruby/2.3.0/timeout.rb:91:in `block in timeout'
/usr/local/lib/ruby/2.3.0/timeout.rb:33:in `block in catch'
/usr/local/lib/ruby/2.3.0/timeout.rb:33:in `catch'
/usr/local/lib/ruby/2.3.0/timeout.rb:33:in `catch'
/usr/local/lib/ruby/2.3.0/timeout.rb:106:in `timeout'
/builds/gitlab-org/gitlab-ee/spec/support/wait_for_ajax.rb:3:in `wait_for_ajax'
/builds/gitlab-org/gitlab-ee/features/steps/shared/diff_note.rb:7:in `block in <module:SharedDiffNote>'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/dsl.rb:160:in `block in define_before_or_after_method_with_block'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/scenario_runner.rb:62:in `block in run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/hookable.rb:81:in `block (3 levels) in run_around_hook'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/reporter.rb:59:in `around_scenario_run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/reporter.rb:36:in `block (2 levels) in bind'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/hookable.rb:80:in `block (2 levels) in run_around_hook'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/hookable.rb:84:in `run_around_hook'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/hookable.rb:44:in `block in around_hook'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/scenario_runner.rb:48:in `run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/feature_runner.rb:69:in `block in run_scenarios!'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/feature_runner.rb:67:in `each'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/feature_runner.rb:67:in `each_with_index'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/feature_runner.rb:67:in `run_scenarios!'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner/feature_runner.rb:48:in `run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner.rb:78:in `block in run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner.rb:74:in `each'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner.rb:74:in `run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/cli.rb:27:in `run'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/gems/spinach-0.8.10/bin/spinach:15:in `<top (required)>'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/bin/spinach:22:in `load'
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.3.0/bin/spinach:22:in `<top (required)>'
At first sight, this doesn't seem related, though.
/cc @iamphill