iPython notebook viewer

What does this MR do?

Adds iPython notebook rendering with a Vue component (see the project https://gitlab.com/gitlab-org/notebooklab). All this code does it renders a different template for notebook files, fetches the raw JSON, parses the JSON and passes it into the Vue component.

It includes markdown rendering (without any GFM references) and syntax highlighting. The syntax highlighting uses our CSS to save anymore CSS being added in.

It is super simple at the moment and probably doesn't work with some more complex notebook files but this can be worked on in the NotebookLab component & then the version updated here when required.

The actual notebook code is tested in the notebooklab repo so the tests here just tests the notebook actually renders on the page rather than also checking how the notebook renders.

There is some simple error handling for when the file is either incorrect JSON or the request fails. I guess the plugin should handle render errors & then display an error there.

Screenshots (if relevant)

What are the relevant issue numbers?

changed title from WIP: Started iPython notebook viewer to WIP:iPython notebook viewer

added 1 commit

• e0fa9973 - Loads raw JSON & displays in the component

Compare with previous version

added 143 commits

• e0fa9973...b075d38c - 140 commits from branch master
• db5721b4 - Started iPython notebook viewer
• e6637ce1 - Loads raw JSON & displays in the component
• 59df76ed - Stops errors in the rendering breaking the page

Compare with previous version

added 1 commit

• 357959e6 - Updated notebooklab library

Compare with previous version

added 183 commits

• 357959e6...51d11190 - 178 commits from branch master
• f9ced97a - Started iPython notebook viewer
• 33f26de5 - Loads raw JSON & displays in the component
• 313258fa - Stops errors in the rendering breaking the page
• e8949a1e - Updated notebooklab library
• 0ef85857 - Added tests

Compare with previous version

added 1 commit

• 32c6ea2d - Updated notebooklab with latest code highlighting changes

Compare with previous version

added 1 commit

• 68f863bd - Fixed spec checking for highlightjs class

Compare with previous version

added frontend label

changed milestone to %9.1

@jschatz1 can you have a look please? Keeping as WIP so it isn't accidentally merged until it is 100% ready.

I guess the notebooklab module should be published to npm as well.

assigned to @jschatz1

added 1 commit

• 0f790dbc - Component now includes scoped styles

Compare with previous version

Awesome!!!

@iamphill I think it's easier to keep things internal rather than having to maintain them externally.

DAMN. It's awesome @iamphill I love it. It renders so fast and it works now.

This file doesn't render and doesn't give an explanation why @iamphill.

04_Neural_Networks.ipynb

unmarked as a Work In Progress

This might be related to https://gitlab.com/gitlab-org/gitlab-ce/issues/24287, which is slated for 9.2 /cc @rspeicher

@iamphill @jschatz1 It looks good to me! I left a one question, but it looks good enough as is! 👍

@iamphill I am going to merge to get this in and so we can find out what works and what doesn't and fix it one at a time.

Thanks @iamphill @grzesiek

resolved all discussions

mentioned in issue #30190 (closed)

approved this merge request

approved this merge request

merged

mentioned in issue #24287 (closed)

mentioned in commit 47aeacd7

mentioned in issue #2508 (closed)

resolved all discussions

@iamphill Should we close https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8486 since this one is merged?

@grzesiek Yeah I think thats a good idea.

/cc @jschatz1 ^

mentioned in issue #30236 (closed)

Hi, I have ipynb files in my repo but I see that none of them render on gitlab.com . Could you inform how to ensure ipynb files are rendered properly and not show the default json.

@vmodi Hi, this will be in GitLab 9.1, so once that is released on the 22nd you will be able to see them (maybe before the 22nd depending when the RC is deployed)

@iamphill I guess it has partially landed and I am stoked to see it happening! :)

There is a problem with inline LaTeX rendering though. When escaped with $$ it is rendered properly, but not inline $<some equation>$ (see screenshot below)

Is this the correct place to leave this info or should I open a new issue? Or am I just doing something wrong?

@zabugr Thanks for feedback! If you could open a new issue so its easier for us to track that'd be great 👍

mentioned in issue #30900 (closed)

@iamphill done. I have also set up a project to test it out with a minimal setup that illustrates the issue. Details are in #30900 (closed)

Hi, I am still facing rendering issue with ipython files. Inline latex doesn't seem to render properly. Is there anyway to make that happen?

mentioned in merge request !8486 (closed)

mentioned in issue #32361 (closed)

mentioned in merge request !11419 (merged)