Add feature tests for real-time pipeline#show and merge_requests#show

Description

Recently Gitlab added a feature of rendering pipeline-mini-graph in real-time for merge request window. And those real-time processing will be adopted little by little into each page, such as pipeline index/show page. However, the test has not fully prepared yet, and the needs would be on demand in the future.

We also need a dedicated mock class of pipeline processing.

e.g.

scenario '...' do
  runner = create_runner(pipeline) # create a runner which processes the pipeline
  expect(page).to have_selector(...)

  # Process the first stage
  runner.start # stage: 'build' - job1 running
  expect(page).to have_selector(...)

  # Finishes the first stage
  runner.proceed_with(:success) # stage: 'build' - job1 success -> stage: 'test' - job2 running
  expect(page).to have_selector(...)
end

(NOTE: This class design may be changed)

Proposal

1. Add feature tests with a dedicated mock class of pipeline processing
2. The MR should reproduce

• https://gitlab.com/gitlab-org/gitlab-ce/issues/31127
• https://gitlab.com/gitlab-org/gitlab-ce/issues/31678
• https://gitlab.com/gitlab-org/gitlab-ce/issues/25226#note_28964273

3. Check the bug will be fixed by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11087

Links / references

Real-time && feature-tests missing

• pipeline#show
• merge_requests#show

Related: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10777

/cc @grzesiek @godfat

I just realized this proposal can't reproduce #31127 (closed), because it's related to Etag cache and that's out of scope.

I think we should still be able to reproduce it with this kind of tests, because the idea is that JavaScript would keep polling, and it's very simple, they don't care about status changes, they just keep asking. The bug is that the server is supposed to respond with 200, but it is responding with 304, which then the browser would think that nothing is changed, but it's wrong.

added ~19173 test labels

changed title from Add a facility of processing pipeline in real-ish for feature tests to Add a helper class processing pipeline in real-time for feature tests

added real-time label

I agree that we need better tools to test our real-time features.

mentioned in merge request !11087 (closed)

changed title from Add a helper class processing pipeline in real-time for feature tests to Add feature tests for real-time pipeline#show and merge_requests#show

mentioned in merge request !11152

@adamniedzielski Hi. I'd like to continue the problem which you gave up at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9036#note_23870071, because that needs to reproduce some ETag related bugs(e.g. #31127 (closed), #31678 (moved), #25226 (closed) (comment 28964273)).

So far, I've found an article mention PhantomJS started supporting Etag cache from 2.1.1. Unfortunately, I've not gotten the desired result yet with the update, but I still believe there may be a workaround.

I've also thrown a question to stackoverflow yesterday. Any suggestion/advice would welcome!

@dosuken123 Thanks for looking into this!

I gave up on feature tests for ETag caching, because I found no sources about that and no evidence that it's possible. The only thing that I found was http://phantomjs.org/api/command-line.html --disk-cache=[true|false]. It defaults to false and I assume that you have to enable it so PhantomJS can store responses.

What I haven't tried is reading the source code of PhantomJS.

@adamniedzielski Thanks! I also tired disk-cache, however, had no luck. If I got good news, I'll let you know!

@adamniedzielski Hi. I've investigated! The thing is selenium + (chrome or firefox) returns If-None-Match, however, poltergeist + PhantomJS does NOT return If-None-Match. I assume there is a bug in PhantomJS, because I could grep etag in the codebase, so that at least they try to deal with it.

Meanwhile, there is a movement of FE dev replacing PhantomJS with headless chrome. Please see more details at https://gitlab.com/gitlab-org/gitlab-ce/issues/30876. I think choosing headless chrome may resolve the If-None-Match problem. That'd be better than fixing PhantomJS which is no longer maintained.

What do you think?

@dosuken123 thanks for your investigation. I think that #30876 (moved) may take a while to do, but still, trying to fix PhantomJS is not worth it.

@adamniedzielski Alright! I'm looking forward to that BE also switch the engine to chrominum!

mentioned in merge request !11333 (merged)

assigned to @dosuken123

removed assignee

moved to gitlab#9374

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue