Follow-up from "Backport of Multiple Assignees feature"
The following discussions from !11089 (merged) should be addressed:
-
@smcgivern started a discussion:
We should split this and
assignee_idby issue / MR, so that we don't acceptassignee_idsfor MRs. -
@smcgivern started a discussion:
case selected_users.length -
@smcgivern started a discussion:
Same as above, we should only permit by issue / MR.
-
@smcgivern started a discussion:
This should probably say 'removed assignee' in CE, but it's really not very important.
-
@smcgivern started a discussion:
- issue.assignees.take(max).each do |assignee| # ... -
@smcgivern started a discussion:
We should probably move these blocks to their own
_sidebar/_assigneepartial -
@smcgivern started a discussion:
This check if it's an MR is redundant now
-
@smcgivern started a discussion:
We could do these in a single hash literal, then merge with
options[:data]. -
@smcgivern started a discussion: (+1 comment)
Is this an array or an AR relation here? If it's a relation, we will perform an extra query for no reason. Try
issue.assignees.to_a.any?. -
@smcgivern started a discussion:
This should also be split into two partials.
-
@smcgivern started a discussion:
We should make this clearer for CE, because in CE there can only be zero or one assignee.
-
@smcgivern started a discussion:
a user -> the users?
-
@smcgivern started a discussion:
We could also use
params.taphere? -
@smcgivern started a discussion: (+1 comment)
Nice!
-
@smcgivern started a discussion:
user -> user
Activity
@ClemMakesApps @vsizov I'll let you divide these between you next week
added ~874211 ~901060 frontend labels
changed milestone to %9.2
assigned to @vsizov
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: (+1 comment) as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: as completed
marked the checklist item @smcgivern started a discussion: (+1 comment) as completed
marked the checklist item @smcgivern started a discussion: as completed
mentioned in merge request !11178 (merged)
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11178
I've fixed BE part and some of FE part (sorry @ClemMakesApps )
created branch
31888-follow-up-from-backport-of-multiple-assignees-feature
