"Username or email" label on login form does not point to its corresponding input field
Summary
When signing into GitLab, the "Username or email" label on login form does not point to its corresponding input field. This is an issue for accessibility (screen readers may not be able to identify the appropriate label for those fields) and for automated tests (which is how I discovered this issue).
Steps to reproduce
- If you are signed, in sign out of GitLab
- On the login form, click the "Username or email" label
What is the current bug behavior?
Clicking the "Username or email" label does not select its corresponding input field.
What is the expected correct behavior?
Clicking the "Username or email" label should select its corresponding input field.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com. (And every other GitLab installation really.)
Possible fixes
The form in question seems to be rendered here: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/devise/sessions/_new_base.html.haml#L3-4 This code should be updated to render the form correctly.
This bug seems to have been introduced in 1dd826d4. I would recommend you update your tests to catch this case.
Related to #31709 (closed), #32034 (closed).