"Project name" label on new project form does not point to its corresponding input field
Summary
When creating a new project in GitLab, the "Project name" label on the form does not point to its corresponding input field. This is an issue for accessibility (screen readers may not be able to identify the appropriate label for those fields) and for automated tests (which is how I discovered this issue).
Steps to reproduce
- Sign in to GitLab
- Click the new project icon in the upper-right corner of the screen
- On the new project form, click the "Project name" label
What is the current bug behavior?
Clicking the "Project name" label does not select its corresponding input field.
What is the expected correct behavior?
Clicking the "Project name" label should select its corresponding input field.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com. (And every other GitLab installation really.)
Possible fixes
The form in question seems to be rendered here: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/projects/new.html.haml#L33-36 This code should be updated to render the form correctly.
I would also recommend you update your tests to catch this case.
Related to #31709 (closed), #32033 (closed).