Push options should be supported
Summary
According to the Git official documentation, I should be able to pass push options to my custom GitLab server-side hooks.
Steps to reproduce
- Run
git push -o foo=bar
What is the current bug behavior?
Operation fails with the following output:
fatal: the receiving end does not support push options
fatal: The remote end hung up unexpectedly
What is the expected correct behavior?
Operation succeed and push options string is passed to the pre-receive hooks.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.11.1 Sidekiq Version:5.0.0
GitLab information Version: 9.2.2 Revision: cbde95c Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: [...] HTTP Clone URL: [...] SSH Clone URL: [...] Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.0.4 Repository storage paths:
- default: /mnt/data/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...
GitLab Shell version >= 5.0.4 ? ... OK (5.0.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 6/1 ... ok 6/2 ... ok 5/3 ... ok 6/5 ... ok 5/6 ... ok 6/9 ... ok 6/10 ... ok 6/11 ... ok 10/12 ... ok 11/13 ... ok 6/14 ... ok 6/15 ... ok 12/16 ... ok 13/17 ... ok 6/18 ... ok 11/19 ... ok 6/20 ... ok 6/21 ... ok 12/22 ... ok 5/23 ... ok 6/24 ... ok 6/25 ... ok 7/26 ... ok 7/27 ... ok 6/29 ... ok 7/30 ... ok 14/31 ... ok 12/32 ... ok 6/33 ... ok 6/34 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory setup correctly? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) projects have namespace: ... 6/1 ... yes 6/2 ... yes 5/3 ... yes 6/5 ... yes 5/6 ... yes 6/9 ... yes 6/10 ... yes 6/11 ... yes 10/12 ... yes 11/13 ... yes 6/14 ... yes 6/15 ... yes 12/16 ... yes 13/17 ... yes 6/18 ... yes 11/19 ... yes 6/20 ... yes 6/21 ... yes 12/22 ... yes 5/23 ... yes 6/24 ... yes 6/25 ... yes 7/26 ... yes 7/27 ... yes 6/29 ... yes 7/30 ... yes 14/31 ... yes 12/32 ... yes 6/33 ... yes 6/34 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.1.0 ? ... yes (2.3.3) Your git bin path is "/opt/gitlab/embedded/bin/git" Git version >= 2.7.3 ? ... yes (2.11.1) Active users: 11
Checking GitLab ... Finished