Skip to content
Snippets Groups Projects
New issue look: Off

Explicitly set font in HTML e-mails

    • Closed (moved) Issue created by username-removed-177500 @ygoe

    The e-mails sent by GitLab are in HTML format but don't set any font to use. MUAs can then decide what font to use to render the message content. Unfortunately, Microsoft Outlook will always use Times New Roman in this case and it's impossible to change that. While one could argue that changing the font would be in the responsibility of Outlook, let's face the fact that Microsoft is probably unable to ever change this. Also, it can't hurt to define a font so e-mails are displayed in a predictable way. (At least this is done for 99.9 % of all websites for the same reason: The user doesn't want to care but still doesn't want it to look ugly.) Some areas like coloured headers already set the "Arial" font, so this should probably be set on the entire message level as well to be consistent.

    Designs

    Child items ...

    • Activity

    • username-removed-386624
      username-removed-386624 @connorshea ·
      Developer

      I believe we do this now, so this should be fixed. Closing.

    • username-removed-386624 Status changed to closed

      Status changed to closed

    • username-removed-177500
      username-removed-177500 @ygoe ·
      Author

      @connorshea I don't share your belief. The very notification e-mail I got for this issue is still in ugly Times New Roman in the Outlook 2010 that I must use.

    • username-removed-386624
      username-removed-386624 @connorshea ·
      Developer

      @ygoe can you provide a screenshot (with anything sensitive blacked out, of course)?

    • username-removed-386624 Status changed to reopened

      Status changed to reopened

    • username-removed-177500
      username-removed-177500 @ygoe ·
      Author

      Here's a screenshot of the last notification message in Outlook:

      GitLabTimesFont

      Here's the e-mail's source code, as reported by Outlook:

      <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd"><html lang="en"><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>
GitLab
</title>


</head>
<body>
<style type="text/css">
img {
max-width: 100%; height: auto;
}
</style>
<div class="content">
<div>
<p><a href="https://gitlab.com/u/ygoe" data-user="177500" data-reference-type="user" class="gfm gfm-project_member" title="Yves Goergen">@ygoe</a> can you provide a screenshot (with anything sensitive blacked out, of course)?</p>
</div>


</div>
<div class="footer" style="margin-top: 10px">
<p style="color: #777; font-size: small">
—
<br>
Reply to this email directly or
<a href="https://gitlab.com/gitlab-org/gitlab-ce/issues/3354#note_13260242">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/**********/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld&#43;json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gitlab-org/gitlab-ce/issues/3354#note_13260242"}}</script>
</p>
</div>
</body>
</html>

      No font set anywhere. Should be at least something like 'sans-serif' or other common fonts. (Not 'Source Sans Pro' please, that already looks ugly in the browser so I've changed it with a user style.)

    • username-removed-57658
      username-removed-57658 @mattl ·
      Contributor

      Hey! It's been at least 2 weeks (and several releases of GitLab) since we heard from you. I'm closing this issue but if you still experience this problem, please open a new issue (but also reference the old issue(s)). Make sure to also include the necessary debugging information conforming to the issue tracker guidelines found in our contributing guidelines.

      Thanks for using GitLab!

    • username-removed-57658 Status changed to closed

      Status changed to closed

    • username-removed-177500
      username-removed-177500 @ygoe ·
      Author

      Well, what more should you hear from me? The issue is still there! Nothing more to add.

    • username-removed-177500 Status changed to reopened

      Status changed to reopened

    • username-removed-57658 Added frontend emails ~131895 labels

      Added frontend emails ~131895 labels

    • username-removed-57658
      username-removed-57658 @mattl ·
      Contributor

      I've labelled this issue now to help other developers find the issue.

    • username-removed-419655 added ~123454 label

      added ~123454 label

    • username-removed-378947 removed ~123454 ~131895 labels

      removed ~123454 ~131895 labels

    • username-removed-378947
      username-removed-378947 @adamniedzielski ·
      Contributor

      @jschatz1 can you confirm that it is something that we want to have?

    • username-removed-177500
      username-removed-177500 @ygoe ·
      Author

      I've seen that you have published a similar screenshot yourself in the blog: https://about.gitlab.com/2016/12/22/gitlab-8-15-released/

    • Felipe Artur moved to gitlab#3905

      moved to gitlab#3905

    • Felipe Artur
      Felipe Artur @felipe_artur ·
      Maintainer

      Hey! :wave:

      GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

      If you have any questions about all of this, please ask them in our dedicated FAQ issue.

      https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

      You can also find more information here:

      Frequently Asked Questions

      For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

      What will we do with the repository names?

      https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

      Why rename gitlab-ce to gitlab-foss?

      Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

      I created a merge requests for CE, and this got closed. What do I need to do?

      You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

      How does the licensing work in this new setup?

      Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

      Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

      No. Merge requests submitted to this project will be closed automatically.

      Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

      Yes.

      How will this affect users of GitLab CE using Omnibus?

      No changes will be necessary, as the packages built remain the same.

      How will this affect users of GitLab CE that build from source?

      Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

      Where can I see a timeline of the remaining steps?

      https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

      Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

      Yes, these changes will be synced to gitlab-foss automatically, several times per day.

    • Felipe Artur locked this issue

      locked this issue

    • Nikola Milojevic mentioned in merge request !14785

      mentioned in merge request !14785

    Please register or sign in to reply