Rename the domain model from `Ci::Variable` to `Ci::ProjectVariable`

Description

After we've done https://gitlab.com/gitlab-org/gitlab-ce/issues/32568 and https://gitlab.com/gitlab-org/gitlab-ce/issues/12729, we also want to refactor Ci::Variable to Ci::ProjectVariable. Because Ci::Variable or variable was meant to be a project thing, but new kinds of variables will be added soon.

---

Plan

We do

• Refactor the domain name from Ci::Variable to Ci::ProjectVariable
• Refactor variable to project_variable in codebase
• Refactor factory from factory :ci_variable to factory :ci_project_variable
• those changes have been included in a Backend MR of Group-wide secret variable, so we'll decouple the change to a new MR

We don't

• Rename table from ci_variables to ci_project_variables

Proposal

Refactor in all codebase (function/tests/doc)

Links / references

• https://gitlab.com/gitlab-org/gitlab-ce/issues/32568
• https://gitlab.com/gitlab-org/gitlab-ce/issues/12729

changed title from Rename Ci::Variable to Ci::ProjectVariable to Rename the domain model from Ci::Variable to Ci::ProjectVariable

changed the description

@ayufan This is an issue which you mentioned we should do in Group-wide secret variable. However, I thought you're misunderstanding my concept, so I explain it here again.

What we'll do is this plan. This doesn't include the table name change. So we only change application code.

The reason why I created this issue is decoupling unnecessary changes from a Backend MR of Group-wide secret variable . We can finish the MR without refactoring. i.e. We'll finish it with Ci::Variable and Ci::GroupVariable.

My whole plan is

1. Implement Ci::PipelineScheduleVariable
2. Implement Ci::GroupVariable
3. Rename from Ci::Variable to Ci::ProjectVariable

Do you think still we need to do this in Group-wide secret variable?

I was thinking if we could not put all these variables in:

module Ci::Variables
  class Project; end
  class Group; end
  class PipelineSchedule; end
end

And, in any case I would name Ci::PipelineScheduleVariable.

@ayufan Yeah, it looks cool. I couldn't understand the advantage, though. Anyway, I just realized the typo. Definitely Ci::PipelineScheduleVariable, it is.

mentioned in merge request !12506

mentioned in merge request !12582 (merged)

added CI/CD label

changed milestone to %9.5

changed milestone to %Backlog

moved to gitlab#10549

Hey! 👋

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue