Copy issue reference does not work on all browsers (Safari, Chrome)

Summary

GitLab 8.2 introduces a button to copy the issue reference on the issue page. This does not work on Safari (I need to check the version when I'm at home) on OSX and on Chrome Version 27.0.1453.110 Linux (I know an old version). However, it works under Chrome (very recent one, I need to check the version when I'm at home) on OSX.

Steps to reproduce

• Use one of the mentioned browsers and clock on the copy button.

Expected behavior

• I should get a copied tooltip notification
• Issue reference is copied to the clipboard

Observed behavior

• There is no tooltip notification and reference is not copied to the clipboard

/cc @rspeicher

mentioned in issue #3530 (closed)

It looks like the copied text gets returned properly by the event, but the document.execCommand('copy') always returns false in Safari. Safari doesn't support the execCommand API as mentioned at the bottom of the Clipboard.js documentation.

I believe the Clipboard.js author intended to use the data-clipboard-text attribute together with the JavaScript event system so that Safari can fallback on the Selection method.

@stanhu Thanks for the info, it helped me get something working.

It looks like Clipboard.js punts on doing a copy in Safari and just uses a fallback to tell the user to hit Option-C:

http://clipboardjs.com/assets/scripts/tooltips.js

mentioned in commit cb3996b1

mentioned in merge request !1844 (merged)

mentioned in commit 2a368021

My MR only addresses the issue with Safari. I don't think we should worry about supporting such an outdated version of Chrome. But maybe the same fix will work too!

Status changed to closed by commit 2a368021

mentioned in commit 34207d1d

mentioned in commit b3cd7243

mentioned in issue #20503 (moved)

mentioned in merge request !14785