GPG verification doesn't load in files commit partial

The verifcation badge doesn't load in the commit partial in both the files view & the main project view

/cc @jschatz1

added diff label

marked this issue as related to #20268 (closed)

@iamphill I can't find the place where you took the screenshot from. Can you tell me where it was?

@winh I saw it on https://dev.gitlab.org/gitlab/gitlabhq/ but it'll only be there if the last commit is signed

I'm setting up GPG and look into this.

assigned to @winh

mentioned in issue #35668 (moved)

added repository and removed bug diff labels

mentioned in merge request !13308 (closed)

I need some backend help for writing a test. We currently have no factory to create a JSON response with signed commits. There seems to be no test for the controller of the JSON response (app/controllers/projects/commits_controller.rb).

This requires some more backend work: Currently the JSON endpoint loads the GPG signatures of all commits while we need only a single one for the repository page. So I think we should pass the commit SHA there.

Maybe it would be a good idea to just remove the GPG signature from the repository page altogether until the backend changes have been made.

@jschatz1 what do you think?

To avoid being dependent on the backend, I have created a new issue for displaying the GPG status (https://gitlab.com/gitlab-org/gitlab-ce/issues/36046) and will focus here on hiding the loading indicator.

mentioned in merge request !13337

mentioned in commit 335ee51e

mentioned in commit 97f251de

mentioned in merge request !13526 (merged)

closed via merge request !13526 (merged)

mentioned in commit 85d38bcd