Failed build email looks broken when unable to load image from gitlab.
Summary
If the email on build failure (probably same on build success but we don't have them enabled) the email looks bad if the images are unable to load.
My suggestion would be to replace the "alt" texts with empty string since these icons doesn't add any value.
Steps to reproduce
Load an email from a failed build without loading images.
What is the current bug behavior?
Alt texts causes email to look broken (at least on gmail) when images cannot load.
What is the expected correct behavior?
Alt texts on images should only be used when they are neccessary, "Branch icon" doesnt add any value. See for instance: https://www.w3.org/WAI/tutorials/images/decorative/
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.13.4 Sidekiq Version:5.0.0 Go Version: unknown
GitLab information Version: 9.4.4 Revision: 2c79d92 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://gitlab.objective.se HTTP Clone URL: http://gitlab.objective.se/some-group/some-project.git SSH Clone URL: git@gitlab.objective.se:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.3.1 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.3.1 ? ... OK (5.3.1) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 8/149 ... ok 8/150 ... ok 8/151 ... ok 8/152 ... ok 8/153 ... ok 8/154 ... ok 8/155 ... ok 8/156 ... ok 8/157 ... ok 8/158 ... ok 8/159 ... ok 8/160 ... ok 8/161 ... ok 8/162 ... ok 8/163 ... ok 8/164 ... ok 8/165 ... ok 8/166 ... ok 8/167 ... ok 8/168 ... ok 8/169 ... ok 8/170 ... ok 8/171 ... ok 8/172 ... ok 8/173 ... ok 8/174 ... ok 8/175 ... ok 8/176 ... ok 8/177 ... ok 8/178 ... ok 8/179 ... ok 8/180 ... ok 8/181 ... ok 8/182 ... ok 8/183 ... ok 8/184 ... ok 8/185 ... ok 8/186 ... ok 8/187 ... ok 8/188 ... ok 8/189 ... ok 8/190 ... ok 8/191 ... ok 8/192 ... ok 8/193 ... ok 8/194 ... ok 8/195 ... ok 8/196 ... ok 8/197 ... ok 8/198 ... ok 8/199 ... ok 8/200 ... ok 8/201 ... ok 8/202 ... ok 8/203 ... ok 8/204 ... ok 8/205 ... ok 8/206 ... ok 8/207 ... ok 8/208 ... ok 8/209 ... ok 8/210 ... ok 8/211 ... ok 8/212 ... ok 8/213 ... ok 8/214 ... ok 8/215 ... ok 8/216 ... ok 8/217 ... ok 8/218 ... ok 8/219 ... ok 8/220 ... ok 8/221 ... ok 8/222 ... ok 8/223 ... ok 8/224 ... repository is empty 8/225 ... ok 8/226 ... ok 8/227 ... ok 8/228 ... ok 8/229 ... ok 8/230 ... ok 8/231 ... ok 8/232 ... ok 8/233 ... ok 8/234 ... ok 8/235 ... ok 8/236 ... ok 8/237 ... ok 8/238 ... ok 8/239 ... ok 8/240 ... ok 8/241 ... ok 8/242 ... ok 8/243 ... ok 8/244 ... ok 8/245 ... ok 8/246 ... ok 8/247 ... ok 8/248 ... ok 8/249 ... ok 8/250 ... ok 8/251 ... ok 8/252 ... ok 8/253 ... ok 8/254 ... ok 8/255 ... ok 8/256 ... ok 8/257 ... ok 8/258 ... ok 8/259 ... ok 8/260 ... ok 8/261 ... ok 8/262 ... ok 8/263 ... ok 8/264 ... ok 8/265 ... ok 8/266 ... ok 8/267 ... ok 8/268 ... ok 8/269 ... ok 8/270 ... ok 8/271 ... ok 8/272 ... ok 8/273 ... ok 8/274 ... ok 8/275 ... ok 8/276 ... ok 8/277 ... ok 8/278 ... ok 8/280 ... ok 8/281 ... ok 8/282 ... ok 8/283 ... ok 8/284 ... ok 14/286 ... ok 8/287 ... ok 8/288 ... ok 1/289 ... ok 1/290 ... ok 8/291 ... ok 8/292 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 8/149 ... yes 8/150 ... yes 8/151 ... yes 8/152 ... yes 8/153 ... yes 8/154 ... yes 8/155 ... yes 8/156 ... yes 8/157 ... yes 8/158 ... yes 8/159 ... yes 8/160 ... yes 8/161 ... yes 8/162 ... yes 8/163 ... yes 8/164 ... yes 8/165 ... yes 8/166 ... yes 8/167 ... yes 8/168 ... yes 8/169 ... yes 8/170 ... yes 8/171 ... yes 8/172 ... yes 8/173 ... yes 8/174 ... yes 8/175 ... yes 8/176 ... yes 8/177 ... yes 8/178 ... yes 8/179 ... yes 8/180 ... yes 8/181 ... yes 8/182 ... yes 8/183 ... yes 8/184 ... yes 8/185 ... yes 8/186 ... yes 8/187 ... yes 8/188 ... yes 8/189 ... yes 8/190 ... yes 8/191 ... yes 8/192 ... yes 8/193 ... yes 8/194 ... yes 8/195 ... yes 8/196 ... yes 8/197 ... yes 8/198 ... yes 8/199 ... yes 8/200 ... yes 8/201 ... yes 8/202 ... yes 8/203 ... yes 8/204 ... yes 8/205 ... yes 8/206 ... yes 8/207 ... yes 8/208 ... yes 8/209 ... yes 8/210 ... yes 8/211 ... yes 8/212 ... yes 8/213 ... yes 8/214 ... yes 8/215 ... yes 8/216 ... yes 8/217 ... yes 8/218 ... yes 8/219 ... yes 8/220 ... yes 8/221 ... yes 8/222 ... yes 8/223 ... yes 8/224 ... yes 8/225 ... yes 8/226 ... yes 8/227 ... yes 8/228 ... yes 8/229 ... yes 8/230 ... yes 8/231 ... yes 8/232 ... yes 8/233 ... yes 8/234 ... yes 8/235 ... yes 8/236 ... yes 8/237 ... yes 8/238 ... yes 8/239 ... yes 8/240 ... yes 8/241 ... yes 8/242 ... yes 8/243 ... yes 8/244 ... yes 8/245 ... yes 8/246 ... yes 8/247 ... yes 8/248 ... yes 8/249 ... yes 8/250 ... yes 8/251 ... yes 8/252 ... yes 8/253 ... yes 8/254 ... yes 8/255 ... yes 8/256 ... yes 8/257 ... yes 8/258 ... yes 8/259 ... yes 8/260 ... yes 8/261 ... yes 8/262 ... yes 8/263 ... yes 8/264 ... yes 8/265 ... yes 8/266 ... yes 8/267 ... yes 8/268 ... yes 8/269 ... yes 8/270 ... yes 8/271 ... yes 8/272 ... yes 8/273 ... yes 8/274 ... yes 8/275 ... yes 8/276 ... yes 8/277 ... yes 8/278 ... yes 8/280 ... yes 8/281 ... yes 8/282 ... yes 8/283 ... yes 8/284 ... yes 14/286 ... yes 8/287 ... yes 8/288 ... yes 1/289 ... yes 1/290 ... yes 8/291 ... yes 8/292 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.3) Git version >= 2.7.3 ? ... yes (2.13.4) Active users: ... 8
Checking GitLab ... Finished
Possible fixes
Remove alt text from <img> tags that are just decorative.