Inconsistent User Fields Included in Log Entries

Summary

Inconsistent user fields included in log entries. For example, below are the log entries created when creating a new user and then impersonating this users:

September 13, 2017 18:47: User "Adam the Admin" (mmclaughlin+vm-adam@gitlab.com) was created
September 13, 2017 18:47: User root has started impersonating adam-the-admin

Note that in the creation log entry the User display name and email are included and not the username. However, in the user impersonate entry only the username is included. It is difficult to connect these entries together as involving the same user.

Please make user log entries include a consistent set of fields. This may be true of other types of logging as well but I am not sure.

cc @MikeWalsh

This was noticed by a large prospective customer: https://na34.salesforce.com/00161000004zrBW

added Platform label

Sounds like this should be relatively easy to fix.

/cc: @DouweM, @briann, @jramsay

Since usernames have to be unique and user "names" don't, it makes more sense to log the username here.

This will need to be adjusted for user removal as well.

def post_destroy_hook
    log_info("User \"#{name}\" (#{email})  was removed")
    system_hook_service.execute_hooks_for(self, :destroy)
end

Should we make this a separate issue?

@mmclaughlin Yes.

/cc @mydigitalself

changed milestone to %Next 3-6 months